Prevent simultaneous charge/discharge plus other minor improvements #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 353085f.
started failing due to expanded NSRDB data?
This reverts commit f7b6e4d.
zolanaj
reviewed
Oct 8, 2024
test/Project.toml
Outdated
There was a problem hiding this comment.
Remove this addition of Logging since it's just for debugging
Comment on lines
+26
to
+46
| @testset "Prevent simultaneous charge and discharge" begin | ||
| logger = SimpleLogger() | ||
| results = nothing | ||
| with_logger(logger) do | ||
| model = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false)) | ||
| results = run_reopt(model, "./scenarios/simultaneous_charge_discharge.json") | ||
| end | ||
| @test any(.&( | ||
| results["ElectricStorage"]["storage_to_load_series_kw"] .!= 0.0, | ||
| ( | ||
| results["ElectricUtility"]["electric_to_storage_series_kw"] .+ | ||
| results["PV"]["electric_to_storage_series_kw"] | ||
| ) .!= 0.0 | ||
| ) | ||
| ) ≈ false | ||
| @test any(.&( | ||
| results["Outages"]["storage_discharge_series_kw"] .!= 0.0, | ||
| results["Outages"]["pv_to_storage_series_kw"] .!= 0.0 | ||
| ) | ||
| ) ≈ false | ||
| end |
Comment on lines
-119
to
120
| (p.production_factor[t, tz+ts-1] + p.unavailability[t][tz+ts-1]) * p.levelization_factor[t] * m[:dvMGRatedProduction][t, s, tz, ts] | ||
| (p.production_factor[t, time_step_wrap_around(tz+ts-1, time_steps_per_hour=p.s.settings.time_steps_per_hour)] + p.unavailability[t][time_step_wrap_around(tz+ts-1, time_steps_per_hour=p.s.settings.time_steps_per_hour)]) * p.levelization_factor[t] * m[:dvMGRatedProduction][t, s, tz, ts] | ||
| ) |
There was a problem hiding this comment.
So the wraparound function is required for data from the initial problem (e.g., production factors and site load) and NOT required for the microgrid state of charge because that's only using the starting time period SOC from the full-year problem and then using the (tz,ts) tuple instead of an "absolute-value" time step that could otherwise exceed 8760. Is that right?
I spot-checked a case and the m[:dvStorageEnergy"] reconciles correctly for the long-duration case in the testset - just making sure I understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
1/p.s.settings.time_steps_per_hourwithp.hours_per_time_stepfor simplicity/consistencyadd_storage_sum_constraintstoadd_storage_sum_grid_constraintsfor clarityAdded
test/Project.tomlbecause it is used inruntests.jlFixed
add_hot_thermal_storage_dispatch_constraintsandadd_cold_thermal_storage_dispatch_constraintsbecause this loop is already done when calling these functions and storage name is passed in as argumentbresults/wind.jl