Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

September 2024 Updates #431

Merged
merged 293 commits into from
Sep 26, 2024
Merged

September 2024 Updates #431

merged 293 commits into from
Sep 26, 2024

Conversation

Bill-Becker
Copy link
Collaborator

@Bill-Becker Bill-Becker commented Aug 9, 2024 •
edited by zolanaj
Loading

zolanaj and others added 30 commits April 26, 2024 14:23
@zolanaj
check for "ElectricHeater" before generating electric heater results
2b34fe9
@zolanaj
fix cooling_cop references
6069afb
@zolanaj
add cooling results for ASHP
4b4cd53
@zolanaj
update ASHP test JSON
df121ce
@zolanaj
Add symbolic names to constraints (similar to other parts of formulat…
8b5835b 
…ion)
@zolanaj
Update ASHP tests and add new test case
378f38b
@zolanaj
Revert "Add symbolic names to constraints (similar to other parts of …
dac9b34 
…formulation)"

This reverts commit 8b5835b.
@zolanaj
fixes for ASHP results
1d2e98a
@zolanaj
update ASHP tests
e7b92b5
@zolanaj
fix ExistingChiller default COP assignment
f71b5b5
@zolanaj
update sets for ASHP constraints to exclude GHP
6347211
@zolanaj
default cooling and heating COPs for GHP formulation
04de091
@atpham88
minor clean up
3c23e46
@atpham88
Merge branch 'add-ASHP' of https://github.com/NREL/REopt.jl into add-…
3391569 
…ASHP
@atpham88
Revert "Merge branch 'add-ASHP' of https://github.com/NREL/REopt.jl i…
21750e0 
…nto add-ASHP"

This reverts commit 3391569, reversing
changes made to 3c23e46.
@zolanaj
cooling_cop, heating_cop for GHP
22c0a57
@zolanaj
update sets for add_ashp_heating_cooling_constraints
2c12c6b
@zolanaj
Add ASHP docs
d21b6d7
@zolanaj
Merge branch 'develop' into add-ASHP
61b70ed
@zolanaj
update tech max sizes to use time-series COPs
1bba5dd
@zolanaj
rm note on process heat loads (which are now in fuel input)
0c763e6
@zolanaj
update notes for heating loads in documentation
0b1683e
@zolanaj
rm tests for ASHP in cplex and xpress
05bcdc0
@zolanaj @atpham88
add todo for cooling COP review
dc8d326 
cc @atpham88

Co-Authored-By: An Pham <[email protected]>
@atpham88
convert ASHP size from mmbtu to ton
032e0d6
@atpham88
updated ashp test
2e7b6c4
@zolanaj
ren ton_per_hour ton (which is a rate)
03f7172
@zolanaj
convert cost conversions to reflect ASHP size in tons
4b3d670
@zolanaj
update ASHP test units
2ee2645
@zolanaj
add get_electric_heater_defaults and get_ashp_defaults to exported fu…
55f5dc5 
…nctions for API
@Bill-Becker Bill-Becker changed the title Improve/Fix GitHub Actions and Track REopt.jl Usage September 2024 Updates Sep 23, 2024
@Bill-Becker Bill-Becker removed the request for review from adfarth September 23, 2024 20:40
zolanaj
zolanaj approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to merge once tests pass

@zolanaj zolanaj merged commit 151b102 into master Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zolanaj zolanaj zolanaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bill-Becker @zolanaj @atpham88 @adfarth @hdunham