Removing scaling factor multiplier & normalization_factor in Sienna Exporter #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 78.49% 78.49%
=======================================
Files 40 40
Lines 4078 4078
=======================================
Hits 3201 3201
Misses 877 877
|
pesap
approved these changes
Feb 7, 2025
…exporter Signed-off-by: mcllerena <[email protected]>
Signed-off-by: mcllerena <[email protected]>
mcllerena
force-pushed
the
ml/remove_sf_norm
branch
from
47e50d5 to
6c4d836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys in ts_pointers: normalization_factor & scaling_factor_multiplier were set to None.
This closes the issue #102