Update to v25.1.0-IOFreeze

[joseph-robertson]

Pull request overview

• Fixes Update to EnergyPlus 25.1.0 #5353

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

Also missing some new variables / variable renames. Will add that shortly: edit see 5c83dd1

[jmarrec]

@joseph-robertson I think your clang format is outdated since you pushed formatting diffs. CI uses 18.1.3.

[jmarrec]

Unfortunately that release is missing the intel mac package which explains why the CI fails for that.
(and doesn't have the arm64 ubuntu ones)

We could use my release here: https://github.com/jmarrec/EnergyPlus/releases/tag/v25.1.0-IOFreeze-Ubuntu-arm64-macfixup

[jmarrec]

@wenyikuang mac is still having issues, can you have a look please?

https://ci.openstudio.net/blue/organizations/jenkins/openstudio-incremental-osx/detail/PR-5354/12/pipeline#step-65-log-38

-- Conan: Target declared 'Ruby::Ruby'
CMake Error at /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/cmakedeps_macros.cmake:67 (message):
  Library 'ruby.3.2-static' not found in package.  If 'ruby.3.2-static' is a
  system library, declare it with 'cpp_info.system_libs' property
Call Stack (most recent call first):
  /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/Ruby-Target-relwithdebinfo.cmake:23 (conan_package_library_targets)
  /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/RubyTargets.cmake:24 (include)
  /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/RubyConfig.cmake:16 (include)
  CMakeLists.txt:431 (find_package)

[ci-commercialbuildings]

CI Results for fd99583:

• Ubuntu 24.04:

• Ubuntu 22.04:

  • OpenStudio-3.10.0-alpha+fd995831cd-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.10.0-alpha+fd995831cd-Ubuntu-22.04-x86_64.tar.gz
  • perf_test/results.html

• Darwin:

• Windows:

  • OpenStudio-3.10.0-alpha+fd995831cd-Windows.exe
  • OpenStudio-3.10.0-alpha+fd995831cd-Windows.tar.gz

• Code Coverage:

[wenyikuang]

@wenyikuang mac is still having issues, can you have a look please?

https://ci.openstudio.net/blue/organizations/jenkins/openstudio-incremental-osx/detail/PR-5354/12/pipeline#step-65-log-38

-- Conan: Target declared 'Ruby::Ruby'
CMake Error at /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/cmakedeps_macros.cmake:67 (message):
  Library 'ruby.3.2-static' not found in package.  If 'ruby.3.2-static' is a
  system library, declare it with 'cpp_info.system_libs' property
Call Stack (most recent call first):
  /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/Ruby-Target-relwithdebinfo.cmake:23 (conan_package_library_targets)
  /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/RubyTargets.cmake:24 (include)
  /Users/jenkins/git/OpenStudioIncremental/OS-build-release-v2/RubyConfig.cmake:16 (include)
  CMakeLists.txt:431 (find_package)

Yeah, fixing it now.

[joseph-robertson]

@joseph-robertson I think your clang format is outdated since you pushed formatting diffs. CI uses 18.1.3.

I think you're right. I updated it, ran it again, and have no diffs.

[jmarrec]

I'm in the process of running an OpenStudio-resources 3 way comparison between OS 3.9.0-E+ 24.2.0, Transition to 25.1.0-IOFreeze, and OS 3.10.0-alpha-E+ 25.1.0-IOFreeze (This PR).

Will report back when I'm done

@joseph-robertson FYI

[jmarrec]

Filed a few issues to E+ repo:

• GetGroundTempModelAndInit: Unable to read Xing EnergyPlus#10981
• ZoneHVAC:CoolingPanel:RadiantConvective:Water change of behavior for Cooling Control Temperature Schedule Name EnergyPlus#10982
• ScheduleDayInterval new error EnergyPlus#10983
• Large diffs between 24.2.0 and 25.1.0-IOFreeze EnergyPlus#10984

There are no diffs that aren't ours:

[jmarrec]

• I filed and closed Should we translate Surfaces onto Spaces rather than Zones starting at 25.1.0? #5363 as this is not needed for us

[jmarrec]

LGTM!