Update to EnergyPlus v24.2.0a

[joseph-robertson]

Pull request overview

• Fixes Update to EnergyPlus 24.2.0 #5240

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for 849d53a:

• Ubuntu 20.04:

• Ubuntu 22.04:

  • OpenStudio-3.9.0-alpha+4b2c04d0df-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.9.0-alpha+4b2c04d0df-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

• Windows:

• Code Coverage:

[jmarrec]

Ok I think this is pretty much ready to drop, except CI is very broken and I don't have the rights to make changes. So it's hard to tell if the tests are green...

I can vouch for Ubuntu (24.04) and macOS (arm64) building just fine.

I have test failures on macOS arm64, but I often have numerical inconsistencies on that machine

Tests I think should be fine on other machines:

	171 - SqlFileFixture.AnnualTotalCosts (Failed)
	464 - GeometryFixture.Plane_RayIntersection (Failed)
	3535 - ISOModelFixture.SimModel (Failed)

Other tests that are suspicious.

	2949 - EnergyPlusFixture.ForwardTranslator_AirTerminalSingleDuctParallelPIUReheat (Failed)
2949: [ RUN      ] EnergyPlusFixture.ForwardTranslator_AirTerminalSingleDuctParallelPIUReheat
2949: /Users/julien/Software/Others/OpenStudio2/src/energyplus/Test/AirTerminalSingleDuctParallelPIUReheat_GTest.cpp:75: Failure
2949: Expected equality of these values:
2949:   atu.nameString() + " Fan Outlet"
2949:     Which is: "Air Terminal Single Duct Parallel PIU Reheat 1 Fan Outlet"
2949:   idf_atu.getString(AirTerminal_SingleDuct_ParallelPIU_ReheatFields::ReheatCoilAirInletNodeName, false).get()
2949:     Which is: "Air Terminal Single Duct Parallel PIU Reheat 1 Mixer Outlet"

	3782 - OpenStudioCLI.Run_RubyPythonPlugin (Failed)

This is an E+ error, and the eplusout.err has

3782: Test command: /Users/julien/Software/Others/OS-build-release2/Products/openstudio "run" "--show-stdout" "-w" "python_plugin_jinja_erb.osw"
3782: Working Directory: /Users/julien/Software/Others/OS-build-release2/resources/workflow/python_plugin/
3782: Test timeout computed to be: 1500
3782: [openstudio.energyplus.ForwardTranslator] <Warn> Object of type 'OS:ThermalZone' and named 'Thermal Zone 1' has DaylightingControl Objects assigned. The interior walls between Spaces will be merged. Make sure these are correctly Matched!
3782: ExpandObjects Started.
3782: No expanded file generated.
3782: ExpandObjects Finished. Time:     0.009
3782: EnergyPlus Starting
3782: EnergyPlus, Version 24.2.0-94a887817b, YMD=2024.10.07 23:36
3782: **FATAL:Python import error causes program termination
3782: EnergyPlus Run Time=00hr 00min  0.06sec
3782: Program terminated: EnergyPlus Terminated--Error(s) Detected.
3782: [openstudio.workflow.OSWorkflow] <Warn> EnergyPlus returned a non-zero exit code (1). Check the stdout-energyplus log
3782: [openstudio.workflow.OSWorkflow] <Fatal> EnergyPlus Terminated with a Fatal Error. Check eplusout.err log.
3782: [openstudio.workflow.OSWorkflow] <Error> Found error in state 'EnergyPlus' with message: '/Users/julien/Software/Others/OpenStudio2/src/workflow/RunEnergyPlus.cpp@311 : EnergyPlus Terminated with a Fatal Error. Check eplusout.err log.'
3782: Failed to run workflow. Last Error:
3782:   Found error in state 'EnergyPlus' with message: '/Users/julien/Software/Others/OpenStudio2/src/workflow/RunEnergyPlus.cpp@311 : EnergyPlus Terminated with a Fatal Error. Check eplusout.err log.'
1/1 Test #3782: OpenStudioCLI.Run_RubyPythonPlugin ...***Failed  Required regular expression not found. Regex=[HI FROM ERB PYTHON PLUGIN[
	 ]*HI FROM JINJA PYTHON PLUGIN
]  1.28 sec

@joseph-robertson can you report on what you find on windows? Does it build? How are tests?

[jmarrec]

Hum the Run_RubyPythonPlugin thing is a codesigning issue, so mac only. I think I can fix it, but it's going to require rebuilding an E+ package...

[jmarrec]

Unbrick the cppcheck workflow... since that one is on Github actions, I can do that. And apparently I had already made a launchpad PPA that built cppcheck 2.3 for focal a year ago (can't remember how I did that...)