Addresses #5227, updates to Controller:OutdoorAir

resources/model/OpenStudio.idd

@@ -22427,15 +22427,15 @@ OS:Controller:OutdoorAir,
        \note This field is only used when the field High Humidity Control = Yes.
        \type real
        \minimum> 0
-       \default 1.0
+       \required-field
   A19, \field Control High Indoor Humidity Based on Outdoor Humidity Ratio
        \note If No is selected, the outdoor air flow rate is modified any time indoor relative
        \note humidity is above the humidistat setpoint. If Yes is selected, the outdoor air
        \note flow rate is modified any time the indoor relative humidity is above the humidistat
        \note setpoint and the outdoor humidity ratio is less than the indoor humidity ratio.
        \note This field is only used when the field High Humidity Control = Yes.
        \type choice
-       \default Yes
+       \required-field
        \key Yes
        \key No
   A20, \field Heat Recovery Bypass Control Type

src/energyplus/ForwardTranslator/ForwardTranslateControllerOutdoorAir.cpp

@@ -9,6 +9,9 @@
 #include "../../model/ControllerMechanicalVentilation.hpp"
 #include "../../model/Node.hpp"
 #include "../../model/Schedule.hpp"
+#include "../../model/ThermalZone.hpp"
+#include "../../model/Curve.hpp"
+#include "../../model/ZoneControlHumidistat.hpp"
 #include <utilities/idd/Controller_OutdoorAir_FieldEnums.hxx>
 #include <utilities/idd/IddEnums.hxx>
 
@@ -119,9 +122,14 @@ namespace energyplus {
     } else {
       idfObject.setString(openstudio::Controller_OutdoorAirFields::EconomizerMaximumLimitDewpointTemperature, "");
     }
+
     ///////////////////////////////////////////////////////////////////////////
     // Field: Electronic Enthalpy Limit Curve Name ////////////////////////////
-    idfObject.setString(openstudio::Controller_OutdoorAirFields::ElectronicEnthalpyLimitCurveName, "");
+    if (boost::optional<model::Curve> curve = modelObject.electronicEnthalpyLimitCurve()) {
+      if (boost::optional<IdfObject> _curve = translateAndMapModelObject(curve.get())) {
+        idfObject.setString(Controller_OutdoorAirFields::ElectronicEnthalpyLimitCurveName, _curve->name().get());
+      }
+    }
 
     ///////////////////////////////////////////////////////////////////////////
     // Field: Economizer Minimum Limit DryBulb Temperature ////////////////////
@@ -151,20 +159,28 @@ namespace energyplus {
       }
     }
 
+    // HumidistatControlZoneName
+    if (auto zone_ = modelObject.humidistatControlZone()) {
+      if (boost::optional<ZoneControlHumidistat> humidistat = zone_->zoneControlHumidistat()) {
+        idfObject.setString(openstudio::Controller_OutdoorAirFields::HumidistatControlZoneName, zone_->nameString());
+      } else {
+        LOG(Warn, modelObject.briefDescription() << " has a humidistat control zone " << zone_->nameString()
+                                                 << " without a zone control humidistat; humidistat control zone field will not be translated");
+        idfObject.setString(openstudio::Controller_OutdoorAirFields::HighHumidityControl, "No");
+      }
+    }
+
     // HighHumidityOutdoorAirFlowRatio
     d = modelObject.getHighHumidityOutdoorAirFlowRatio();
     if (d) {
       idfObject.setDouble(openstudio::Controller_OutdoorAirFields::HighHumidityOutdoorAirFlowRatio, *d);
     }
 
     // ControlHighIndoorHumidityBasedonOutdoorHumidityRatio
-    ob = modelObject.getControlHighIndoorHumidityBasedOnOutdoorHumidityRatio();
-    if (ob) {
-      if (*ob) {
-        idfObject.setString(openstudio::Controller_OutdoorAirFields::ControlHighIndoorHumidityBasedonOutdoorHumidityRatio, "Yes");
-      } else {
-        idfObject.setString(openstudio::Controller_OutdoorAirFields::ControlHighIndoorHumidityBasedonOutdoorHumidityRatio, "No");
-      }
+    if (modelObject.getControlHighIndoorHumidityBasedOnOutdoorHumidityRatio()) {
+      idfObject.setString(openstudio::Controller_OutdoorAirFields::ControlHighIndoorHumidityBasedonOutdoorHumidityRatio, "Yes");
+    } else {
+      idfObject.setString(openstudio::Controller_OutdoorAirFields::ControlHighIndoorHumidityBasedonOutdoorHumidityRatio, "No");
     }
 
     // HeatRecoveryBypassControlType

src/energyplus/ReverseTranslator/ReverseTranslateControllerOutdoorAir.cpp

@@ -6,6 +6,14 @@
 #include "../ReverseTranslator.hpp"
 #include "../../model/ControllerOutdoorAir.hpp"
 #include "../../model/ControllerOutdoorAir_Impl.hpp"
+#include "../../model/ThermalZone.hpp"
+#include "../../model/ThermalZone_Impl.hpp"
+#include "../../model/Space.hpp"
+#include "../../model/Space_Impl.hpp"
+#include "../../model/Curve.hpp"
+#include "../../model/Curve_Impl.hpp"
+#include "../../model/Schedule.hpp"
+#include "../../model/Schedule_Impl.hpp"
 #include <utilities/idd/Controller_OutdoorAir_FieldEnums.hxx>
 #include "../../utilities/idd/IddEnums.hpp"
 #include <utilities/idd/IddEnums.hxx>
@@ -22,6 +30,9 @@ namespace energyplus {
       return boost::none;
     }
 
+    boost::optional<WorkspaceObject> _wo;
+    boost::optional<ModelObject> _mo;
+
     ControllerOutdoorAir mo(m_model);
 
     boost::optional<std::string> s = workspaceObject.getString(Controller_OutdoorAirFields::Name);
@@ -64,9 +75,14 @@ namespace energyplus {
       mo.setEconomizerMaximumLimitDewpointTemperature(value.get());
     }
 
-    s = workspaceObject.getString(Controller_OutdoorAirFields::ElectronicEnthalpyLimitCurveName);
-    if (s) {
-      LOG(Error, "ControllerOutdoorAir " << workspaceObject.briefDescription() << " references a curve that is not supported");
+    if ((_wo = workspaceObject.getTarget(Controller_OutdoorAirFields::ElectronicEnthalpyLimitCurveName))) {
+      if ((_mo = translateAndMapWorkspaceObject(_wo.get()))) {
+        if (boost::optional<Curve> _curve = _mo->optionalCast<Curve>()) {
+          mo.setElectronicEnthalpyLimitCurve(_curve.get());
+        } else {
+          LOG(Warn, workspaceObject.briefDescription() << " has a wrong type for 'Electronic Enthalpy Limit Curve Name'");
+        }
+      }
     }
 
     value = workspaceObject.getDouble(Controller_OutdoorAirFields::EconomizerMinimumLimitDryBulbTemperature);
@@ -84,22 +100,34 @@ namespace energyplus {
       mo.setMinimumLimitType(s.get());
     }
 
-    s = workspaceObject.getString(Controller_OutdoorAirFields::MinimumOutdoorAirScheduleName);
-    if (s) {
-      LOG(Warn,
-          "ControllerOutdoorAir " << workspaceObject.briefDescription() << " references a minimum outdoor air schedule, which is not supported");
+    if ((_wo = workspaceObject.getTarget(Controller_OutdoorAirFields::MinimumOutdoorAirScheduleName))) {
+      if ((_mo = translateAndMapWorkspaceObject(_wo.get()))) {
+        if (boost::optional<Schedule> _schedule = _mo->optionalCast<Schedule>()) {
+          mo.setMinimumOutdoorAirSchedule(_schedule.get());
+        } else {
+          LOG(Warn, workspaceObject.briefDescription() << " has a wrong type for 'Minimum Outdoor Air Schedule Name'");
+        }
+      }
     }
 
-    s = workspaceObject.getString(Controller_OutdoorAirFields::MinimumFractionofOutdoorAirScheduleName);
-    if (s) {
-      LOG(Warn, "ControllerOutdoorAir " << workspaceObject.briefDescription()
-                                        << " references a minimum fraction of outdoor air schedule, which is not supported");
+    if ((_wo = workspaceObject.getTarget(Controller_OutdoorAirFields::MinimumFractionofOutdoorAirScheduleName))) {
+      if ((_mo = translateAndMapWorkspaceObject(_wo.get()))) {
+        if (boost::optional<Schedule> _schedule = _mo->optionalCast<Schedule>()) {
+          mo.setMinimumFractionofOutdoorAirSchedule(_schedule.get());
+        } else {
+          LOG(Warn, workspaceObject.briefDescription() << " has a wrong type for 'Minimum Fraction of Outdoor Air Schedule Name'");
+        }
+      }
     }
 
-    s = workspaceObject.getString(Controller_OutdoorAirFields::MaximumFractionofOutdoorAirScheduleName);
-    if (s) {
-      LOG(Warn, "ControllerOutdoorAir " << workspaceObject.briefDescription()
-                                        << " references a maximum fraction of outdoor air schedule, which is not supported");
+    if ((_wo = workspaceObject.getTarget(Controller_OutdoorAirFields::MaximumFractionofOutdoorAirScheduleName))) {
+      if ((_mo = translateAndMapWorkspaceObject(_wo.get()))) {
+        if (boost::optional<Schedule> _schedule = _mo->optionalCast<Schedule>()) {
+          mo.setMaximumFractionofOutdoorAirSchedule(_schedule.get());
+        } else {
+          LOG(Warn, workspaceObject.briefDescription() << " has a wrong type for 'Maximum Fraction of Outdoor Air Schedule Name'");
+        }
+      }
     }
 
     s = workspaceObject.getString(Controller_OutdoorAirFields::MechanicalVentilationControllerName);
@@ -108,24 +136,27 @@ namespace energyplus {
           "ControllerOutdoorAir " << workspaceObject.briefDescription() << " references a mechanical ventilation controller, which is not supported");
     }
 
-    s = workspaceObject.getString(Controller_OutdoorAirFields::TimeofDayEconomizerControlScheduleName);
-    if (s) {
-      LOG(Warn, "ControllerOutdoorAir " << workspaceObject.briefDescription()
-                                        << " references a time of day economizer control schedule, which is not supported");
-    }
-
-    s = workspaceObject.getString(Controller_OutdoorAirFields::HighHumidityControl);
-    if (s) {
-      if (istringEqual("Yes", s.get())) {
-        mo.setHighHumidityControl(true);
-      } else {
-        mo.setHighHumidityControl(false);
+    if ((_wo = workspaceObject.getTarget(Controller_OutdoorAirFields::TimeofDayEconomizerControlScheduleName))) {
+      if ((_mo = translateAndMapWorkspaceObject(_wo.get()))) {
+        if (boost::optional<Schedule> _schedule = _mo->optionalCast<Schedule>()) {
+          mo.setTimeofDayEconomizerControlSchedule(_schedule.get());
+        } else {
+          LOG(Warn, workspaceObject.briefDescription() << " has a wrong type for 'Time of Day Economizer Control Schedule Name'");
+        }
       }
     }
 
-    s = workspaceObject.getString(Controller_OutdoorAirFields::HumidistatControlZoneName);
-    if (s) {
-      LOG(Warn, "ControllerOutdoorAir " << workspaceObject.briefDescription() << " references a high humidity control zone, which is not supported");
+    if ((_wo = workspaceObject.getTarget(Controller_OutdoorAirFields::HumidistatControlZoneName))) {
+      if ((_mo = translateAndMapWorkspaceObject(_wo.get()))) {
+        // Zone is translated, and a Space is returned instead
+        if (boost::optional<Space> space_ = _mo->optionalCast<Space>()) {
+          if (auto z_ = space_->thermalZone()) {
+            mo.setHumidistatControlZone(z_.get());
+          }
+        } else {
+          LOG(Warn, workspaceObject.briefDescription() << " has a wrong type for 'Humidistat Control Zone Name'");
+        }
+      }
     }
 
     value = workspaceObject.getDouble(Controller_OutdoorAirFields::HighHumidityOutdoorAirFlowRatio);

src/energyplus/ReverseTranslator/ReverseTranslateFanSystemModel.cpp

@@ -133,6 +133,7 @@ namespace energyplus {
         }
       }
     }
+
     // Night Ventilation Mode Pressure Rise: Optional Double
     if (boost::optional<double> _nightVentilationModePressureRise =
           workspaceObject.getDouble(Fan_SystemModelFields::NightVentilationModePressureRise)) {

src/model/AirConditionerVariableRefrigerantFlow.cpp

@@ -1064,7 +1064,6 @@ namespace model {
 
     bool AirConditionerVariableRefrigerantFlow_Impl::setHeatPumpWasteHeatRecovery(bool heatPumpWasteHeatRecovery) {
       return setBooleanFieldValue(OS_AirConditioner_VariableRefrigerantFlowFields::HeatPumpWasteHeatRecovery, heatPumpWasteHeatRecovery);
-      ;
     }
 
     bool AirConditionerVariableRefrigerantFlow_Impl::setEquivalentPipingLengthusedforPipingCorrectionFactorinCoolingMode(