Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses #5214, EpwFile getTimeSeries fails for leap year weather file w/no leap day #5217

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
+26,418 −8
Open

Addresses #5214, EpwFile getTimeSeries fails for leap year weather file w/no leap day #5217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9c2dbec
Add a new epw test file.
joseph-robertson Jun 4, 2024
9f60033
Add a failing test for getTimeSeries.
joseph-robertson Jun 4, 2024
80043b8
Try forcing the isActual block.
joseph-robertson Jun 4, 2024
718493e
Try an optional bool in getTimeSeries.
joseph-robertson Jun 4, 2024
5017a02
Try the new optional in the test.
joseph-robertson Jun 4, 2024
2523e6e
Try a different variable name.
joseph-robertson Jun 4, 2024
6c8d765
Another test for TMY with leap Feb.
joseph-robertson Jun 4, 2024
5bee247
Include a test for each of the bad date scenarios.
joseph-robertson Jun 4, 2024
5739c51
Try approach of setting 2009-Feb-29 00:00:00 to 2009-Mar-01 00:00:00.
joseph-robertson Jun 4, 2024
8497139
Try cleaning up the tests.
joseph-robertson Jun 5, 2024
bbf02eb
Update epw filenames and fix test.
joseph-robertson Jun 5, 2024
97fb63c
Try a different approach of returning the correct m_data.
joseph-robertson Jun 5, 2024
8e65308
Fix test.
joseph-robertson Jun 5, 2024
d7de25d
Pre-scan epw lines for realYear, then again for m_data load.
joseph-robertson Jun 5, 2024
1066d84
Typo.
joseph-robertson Jun 6, 2024
17248ce
Update approach using a struct.
joseph-robertson Jun 7, 2024
eb2ab10
Try unsigned int.
joseph-robertson Jun 7, 2024
17d344f
Update some comments.
joseph-robertson Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions resources/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,16 @@ set(utilities_resources_src
utilities/Checksum/Checksum2.txt
utilities/Filetypes/CHN_Guangdong.Shaoguan.590820_CSWD.epw
utilities/Filetypes/USA_CO_Golden-NREL.724666_TMY3.epw
utilities/Filetypes/USA_CO_Golden-NREL.724666_TMY3-leapday.epw
utilities/Filetypes/USA_CO_Golden-NREL.724666_TMY3-noleapday.epw
utilities/Filetypes/USA_CO_Golden-NREL.wrap.epw
utilities/Filetypes/USA_CO_Golden-NREL.amy
utilities/Filetypes/USA_CO_Golden-NREL.wrap.amy
utilities/Filetypes/USA_CT_New.Haven-Tweed.AP.725045_TMY3.epw
utilities/Filetypes/TDV_2008_kBtu_CZ13.csv
utilities/Filetypes/TUN_Tunis.607150_IWEC.epw
utilities/Filetypes/leapday-test.epw
utilities/Filetypes/leapday-test-noleapday.epw
utilities/Filetypes/min.osw
utilities/Filetypes/full.osw
utilities/Filetypes/test_csv.csv
Expand Down
Loading
Loading