Handle incomplete EPW design conditions header

[joseph-robertson]

Pull request overview

• Fixes EPWDesignCondition getters should return boost::optional #5132.
• EpwDesignCondition has many API-breaking changes related to its getters. The previous behavior was to misleadingly return a value of 0 for any empty design condition header field. The types for the getters are now either boost::optional<double> or boost::optional<int>.

Notes:

• Does stringToDouble return 0.0 if an empty string is passed in? Yes.
• Should the following changes be made to EpwFile.hpp / EpwFile.cpp:
  • check for empty strings in setters; e.g., check heatingDryBulb99 is empty string in setHeatingDryBulb99? Yes.
  • change all getters to return boost::optional<double>; e..g, double EpwDesignCondition::heatingDryBulb99() const { to boost::optional<double> EpwDesignCondition::heatingDryBulb99() const {? Yes.
  • change, e.g., double m_heatingDryBulb99 to boost::optional<double> m_heatingDryBulb99 in EpwDesignCondition class? Yes.

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for be61615:

• Ubuntu 20.04:

  • OpenStudio-3.8.0+be616158b1-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.8.0+be616158b1-Ubuntu-20.04-x86_64.tar.gz
  • perf_test/results.html

• Ubuntu 22.04:

  • OpenStudio-3.8.0+be616158b1-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.8.0+be616158b1-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.8.0+be616158b1-Darwin-x86_64.dmg
  • OpenStudio-3.8.0+be616158b1-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0+be616158b1-Windows.exe
  • OpenStudio-3.8.0+be616158b1-Windows.tar.gz

• Code Coverage: