Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI 301-2022: Batteries #704

Merged
merged 14 commits into from
Jan 19, 2024
Merged

ANSI 301-2022: Batteries #704

merged 14 commits into from
Jan 19, 2024

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Jan 9, 2024

Pull Request Description

Allows modeling electric battery storage, including shared batteries ("2022C" or newer).

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@shorowit shorowit self-assigned this Jan 9, 2024
GitHub Action and others added 13 commits January 9, 2024 03:31
231e0b2ae3 Add references for prorating. [ci skip]
fae910bf79 Allows shared batteries (batteries serving multiple dwelling units). Battery charging/discharging will be apportioned to the dwelling unit using its number of bedrooms divided by the total number of bedrooms served by the battery.
c102844ee2 Oops.
d6d594c8e8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022
513acded4f Latest results.
ce3851566e Merge branch 'master' into ansi_301_2022
bdbf9cd0de Latest results.
67848fe81e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022
a9d0011a12 Latest results.
cb3775f586 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022
25cade3703 Latest results.
6a137735c6 Remove natural ventilation RH constraint to comply with ANSI 301-2022; HR constraint is still in place.
fe3dc91a5c Update default CFIS fan power. Fix ANSI 301 links in docs.
85b40864fe Update Qinf=f(NL) equation.
bddcef9920 Prep for ANSI 301-2022.

git-subtree-dir: hpxml-measures
git-subtree-split: 231e0b2ae33550c9e8aefb2180c58cef0bcf49cc
…_2022_batteries

# Conflicts:
#	hpxml-measures/HPXMLtoOpenStudio/measure.xml
f93fb1da3d Exclude appliance schema changes for this branch.

git-subtree-dir: hpxml-measures
git-subtree-split: f93fb1da3dc281b2ab73ce26ef87452d4f6d00e7
…into ansi_302_2022_batteries

# Conflicts:
#	Changelog.md
#	hpxml-measures/BuildResidentialHPXML/measure.xml
#	hpxml-measures/HPXMLtoOpenStudio/measure.xml
#	hpxml-measures/docs/source/workflow_inputs.rst
#	workflow/tests/base_results/sample_files.csv
@shorowit shorowit marked this pull request as ready for review January 19, 2024 20:34
@shorowit shorowit merged commit 57c0421 into ansi_301_2022 Jan 19, 2024
0 of 8 checks passed
@shorowit shorowit deleted the ansi_302_2022_batteries branch January 19, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant