Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZERH v2: Use ASRE instead of SRE for mech vent #683

Merged
merged 6 commits into from
Jul 28, 2023
Merged

ZERH v2: Use ASRE instead of SRE for mech vent #683

merged 6 commits into from
Jul 28, 2023

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Jul 24, 2023 •
edited by shorowit
Loading

Pull Request Description

ZERH v2: Use ASRE instead of SRE for mech vent

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@bpark1327 bpark1327 added the bug label Jul 24, 2023
@bpark1327 bpark1327 self-assigned this Jul 24, 2023
@bpark1327 bpark1327 linked an issue Jul 24, 2023 that may be closed by this pull request
ZERH v2 ruleset should use ASRE not SRE for mech vent #682
Closed
@bpark1327 bpark1327 marked this pull request as ready for review July 25, 2023 14:58
@bpark1327 bpark1327 requested a review from shorowit July 25, 2023 14:58
shorowit
shorowit approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@shorowit shorowit merged commit 2ee6cf9 into master Jul 28, 2023
@shorowit shorowit deleted the zerh_v2_use_asre branch July 28, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit approved these changes

Assignees

@bpark1327 bpark1327

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZERH v2 ruleset should use ASRE not SRE for mech vent
2 participants
@bpark1327 @shorowit