Skip to content

Commit

Permalink
Change TODO note to something more helpful
Browse files Browse the repository at this point in the history
  • Loading branch information
@jmaack24
jmaack24 committed Nov 9, 2022
1 parent fa9f6e0 commit e578381
Showing 1 changed file with 25 additions and 60 deletions.
85 changes: 25 additions & 60 deletions languages/julia/julia-tutorial/source-notebooks/Julia-Parallel-Computing.ipynb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
{
"data": {
"text/plain": [
"Task (runnable) @0x00000001136e97b0"
"Task (runnable) @0x000000010f9db5e0"
]
},
"execution_count": 2,
Expand Down Expand Up @@ -184,7 +184,7 @@
{
"data": {
"text/plain": [
"Task (runnable) @0x0000000133a55660"
"Task (runnable) @0x000000010fba3b20"
]
},
"execution_count": 3,
Expand Down Expand Up @@ -223,7 +223,7 @@
{
"data": {
"text/plain": [
"Task (done) @0x0000000133a55660"
"Task (done) @0x000000010fba3b20"
]
},
"execution_count": 4,
Expand Down Expand Up @@ -260,7 +260,7 @@
{
"data": {
"text/plain": [
"Task (done) @0x0000000112f3a8c0"
"Task (done) @0x00000001104d5f90"
]
},
"execution_count": 5,
Expand Down Expand Up @@ -299,7 +299,7 @@
{
"data": {
"text/plain": [
"0.0002668053796949929"
"-0.001273303473691948"
]
},
"execution_count": 6,
Expand Down Expand Up @@ -383,8 +383,8 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 19.574 ms (1 allocation: 144 bytes)\n",
" 19.532 ms (74 allocations: 5.52 KiB)\n"
" 19.958 ms (1 allocation: 144 bytes)\n",
" 19.979 ms (74 allocations: 5.52 KiB)\n"
]
}
],
Expand Down Expand Up @@ -565,7 +565,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 19.583 ms (24 allocations: 1.72 KiB)\n"
" 19.941 ms (24 allocations: 1.72 KiB)\n"
]
}
],
Expand Down Expand Up @@ -730,7 +730,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 9.824 ms (14 allocations: 1.14 KiB)\n"
" 10.023 ms (13 allocations: 1.14 KiB)\n"
]
}
],
Expand Down Expand Up @@ -787,7 +787,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 9.946 ms (124 allocations: 9.89 KiB)\n"
" 10.175 ms (124 allocations: 9.89 KiB)\n"
]
}
],
Expand Down Expand Up @@ -847,7 +847,7 @@
},
{
"cell_type": "code",
"execution_count": 41,
"execution_count": 19,
"id": "6d421c85",
"metadata": {
"slideshow": {
Expand All @@ -856,45 +856,10 @@
},
"outputs": [
{
"ename": "LoadError",
"evalue": "TaskFailedException\n\n\u001b[91m nested task error: \u001b[39mInvalidStateException: Channel is closed.\n Stacktrace:\n [1] \u001b[0m\u001b[1mtry_yieldto\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90mundo\u001b[39m::\u001b[0mtypeof(Base.ensure_rescheduled)\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mtask.jl:871\u001b[24m\u001b[39m\n [2] \u001b[0m\u001b[1mwait\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mtask.jl:931\u001b[24m\u001b[39m\n [3] \u001b[0m\u001b[1mwait\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90mc\u001b[39m::\u001b[0mBase.GenericCondition\u001b[90m{ReentrantLock}\u001b[39m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mcondition.jl:124\u001b[24m\u001b[39m\n [4] \u001b[0m\u001b[1mtake_buffered\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90mc\u001b[39m::\u001b[0mChannel\u001b[90m{Float64}\u001b[39m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mchannels.jl:416\u001b[24m\u001b[39m\n [5] \u001b[0m\u001b[1mtake!\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90m./\u001b[39m\u001b[90m\u001b[4mchannels.jl:410\u001b[24m\u001b[39m\u001b[90m [inlined]\u001b[39m\n [6] \u001b[0m\u001b[1maccumulator\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90minput\u001b[39m::\u001b[0mChannel\u001b[90m{Float64}\u001b[39m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[35mMain\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mIn[10]:5\u001b[24m\u001b[39m\n [7] \u001b[0m\u001b[1m(::var\"#21#23\"{Channel{Float64}})\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[35mMain\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mthreadingconstructs.jl:258\u001b[24m\u001b[39m",
"output_type": "error",
"traceback": [
"TaskFailedException\n\n\u001b[91m nested task error: \u001b[39mInvalidStateException: Channel is closed.\n Stacktrace:\n [1] \u001b[0m\u001b[1mtry_yieldto\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90mundo\u001b[39m::\u001b[0mtypeof(Base.ensure_rescheduled)\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mtask.jl:871\u001b[24m\u001b[39m\n [2] \u001b[0m\u001b[1mwait\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mtask.jl:931\u001b[24m\u001b[39m\n [3] \u001b[0m\u001b[1mwait\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90mc\u001b[39m::\u001b[0mBase.GenericCondition\u001b[90m{ReentrantLock}\u001b[39m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mcondition.jl:124\u001b[24m\u001b[39m\n [4] \u001b[0m\u001b[1mtake_buffered\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90mc\u001b[39m::\u001b[0mChannel\u001b[90m{Float64}\u001b[39m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90mBase\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mchannels.jl:416\u001b[24m\u001b[39m\n [5] \u001b[0m\u001b[1mtake!\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[90m./\u001b[39m\u001b[90m\u001b[4mchannels.jl:410\u001b[24m\u001b[39m\u001b[90m [inlined]\u001b[39m\n [6] \u001b[0m\u001b[1maccumulator\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[90minput\u001b[39m::\u001b[0mChannel\u001b[90m{Float64}\u001b[39m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[35mMain\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mIn[10]:5\u001b[24m\u001b[39m\n [7] \u001b[0m\u001b[1m(::var\"#21#23\"{Channel{Float64}})\u001b[22m\u001b[0m\u001b[1m(\u001b[22m\u001b[0m\u001b[1m)\u001b[22m\n \u001b[90m @ \u001b[39m\u001b[35mMain\u001b[39m \u001b[90m./\u001b[39m\u001b[90m\u001b[4mthreadingconstructs.jl:258\u001b[24m\u001b[39m",
"",
"Stacktrace:",
" [1] wait",
" @ ./task.jl:345 [inlined]",
" [2] fetch",
" @ ./task.jl:360 [inlined]",
" [3] run_mci_mt3()",
" @ Main ./In[18]:5",
" [4] var\"##core#408\"()",
" @ Main ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:489",
" [5] var\"##sample#409\"(::Tuple{}, __params::BenchmarkTools.Parameters)",
" @ Main ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:497",
" [6] _lineartrial(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; maxevals::Int64, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})",
" @ BenchmarkTools ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:161",
" [7] _lineartrial(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters)",
" @ BenchmarkTools ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:152",
" [8] #invokelatest#2",
" @ ./essentials.jl:729 [inlined]",
" [9] invokelatest",
" @ ./essentials.jl:726 [inlined]",
" [10] #lineartrial#46",
" @ ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:35 [inlined]",
" [11] lineartrial",
" @ ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:35 [inlined]",
" [12] tune!(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; progressid::Nothing, nleaves::Float64, ndone::Float64, verbose::Bool, pad::String, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})",
" @ BenchmarkTools ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:251",
" [13] tune! (repeats 2 times)",
" @ ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:247 [inlined]",
" [14] top-level scope",
" @ ~/.julia/packages/BenchmarkTools/7xSXH/src/execution.jl:576",
" [15] eval",
" @ ./boot.jl:368 [inlined]",
" [16] include_string(mapexpr::typeof(REPL.softscope), mod::Module, code::String, filename::String)",
" @ Base ./loading.jl:1428"
"name": "stdout",
"output_type": "stream",
"text": [
" 20.053 ms (31 allocations: 1.64 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1190,7 +1155,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 10.065 ms (143 allocations: 6.67 KiB)\n"
" 10.353 ms (143 allocations: 6.67 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1295,7 +1260,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 11.928 ms (1233 allocations: 52.48 KiB)\n"
" 12.504 ms (1204 allocations: 51.97 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1351,7 +1316,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 1.740 ms (100 allocations: 4.13 KiB)\n"
" 1.749 ms (99 allocations: 4.10 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1407,7 +1372,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 164.427 μs (92 allocations: 3.87 KiB)\n"
" 163.867 μs (90 allocations: 3.80 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1438,7 +1403,7 @@
}
},
"source": [
"**TODO:** Do I want to do this bit?"
"**INFO:** The following section on SharedArrays may be helpful to include in a future version."
]
},
{
Expand Down Expand Up @@ -1487,7 +1452,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 10.536 ms (605 allocations: 29.14 KiB)\n"
" 10.825 ms (608 allocations: 29.23 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1542,7 +1507,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 10.850 ms (493 allocations: 21.78 KiB)\n"
" 11.196 ms (477 allocations: 21.28 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1658,7 +1623,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
" 11.281 ms (1130 allocations: 46.59 KiB)\n"
" 11.588 ms (1127 allocations: 46.50 KiB)\n"
]
}
],
Expand Down Expand Up @@ -1693,7 +1658,7 @@
{
"data": {
"text/plain": [
"Task (done) @0x0000000112924010"
"Task (done) @0x000000010ec78fd0"
]
},
"execution_count": 40,
Expand Down Expand Up @@ -1969,7 +1934,7 @@
"file_extension": ".jl",
"mimetype": "application/julia",
"name": "julia",
"version": "1.8.1"
"version": "1.8.2"
}
},
"nbformat": 4,
Expand Down

0 comments on commit e578381

Please sign in to comment.