Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise utility rate results #295

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Revise utility rate results #295

wants to merge 17 commits into from

Conversation

eringold
Copy link
Contributor

@eringold eringold commented Mar 7, 2025

Pull request overview

Fixes the issue of utility rate results not aligning with the apportioned building locations by:

  • At workflow runtime, calculating all applicable utility rates for all potential tracts in the model's sampling region
  • Reporting the min/max/median/mean/state average rate bills and rate labels for all applicable bills for all possible eventual locations,
  • In postprocessing, after the results are apportioned and weights calculated, parse the final location's utility results from the measure output, and compute weighted bills, bill savings and cost intensities

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@eringold eringold added workflow measure PR improves or adds baseline workflow measures postprocessing PR improves or adds postprocessing content Pull Request - Ready for CI labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postprocessing PR improves or adds postprocessing content Pull Request - Ready for CI workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant