Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RT, XT, ZR, ZX parameters to ext dict for generator. #1268

Closed
wants to merge 47 commits into from
Closed

Add RT, XT, ZR, ZX parameters to ext dict for generator. #1268

wants to merge 47 commits into from

Conversation

mcllerena
Copy link

Put RT, XT fields into the ext dictionary. Since ZR & ZX where already added.

rodrigomha and others added 30 commits January 10, 2025 14:51
@rodrigomha
add 3W xfrm
4521353
@rodrigomha
update optional fields
ce4caec
@rodrigomha
Merge pull request NREL-Sienna#1247 from NREL-Sienna/rh/3w_xfmr
a904648 
[DRAFT] [PSY5] Add 3W Transformer Struct
@mcllerena
parse missing sw shunt data in psse.jl file
7144b82
@mcllerena
adding keys to distinguish between fixed & switched shunts
8f19a20
@mcllerena
Emptying the contents of the 'shunt' key, since keys for fixed & swit…
1aad3a0 
…ched were created
@mcllerena
add Switch Shunt struct & psse.jl updates on 3WT
cf0ef24
@mcllerena
adding missing parameters to 3wtransformer
a4cf206
@rodrigomha
formatter
f013e53
@rodrigomha
revert typo
647251e
@rodrigomha
add buses to 3w dics
cecf352
@rodrigomha
add bus ids to the 3w parser
433c9d2
@rodrigomha
handle addition of 3w transformer
4b8c134
@rodrigomha
implement parser of 3W XFRM to system
8c0e02f
@mcllerena
make complex the y_increment in the switched shunt
eb8269b
@mcllerena
add make and read switched shunt functions
d973051
@mcllerena
filter zero values on switched shunt vectors
53e8fd9
@rodrigomha
fix sw adm default bug
6d481cd
@rodrigomha
clear sys for serialized test
420ff7f
@rodrigomha
update switched admittance types
8ef70c2
@mcllerena
add new test and 5circuit 3w archives
35a81c4
@rodrigomha @mcllerena
Update parser methods for 3W and Switched Shunt
87a91f6 
Co-authored-by: mcllerena <[email protected]>
@rodrigomha @mcllerena
update psse parser tests for 3w and switched shunts
51534b3 
Co-authored-by: mcllerena <[email protected]>
@annacasavant @rodrigomha
updated get_components.
3785aa8
@annacasavant @rodrigomha
Grammar Fixes
f280672
@annacasavant @rodrigomha
grammar
558cd3e
@annacasavant @rodrigomha
removed fuel (@ref)
bfd71a2
@annacasavant @rodrigomha
fixing (@ref)
1038543
@annacasavant @rodrigomha
needed to get rid of the "@ref"
f074623
@kdayday @rodrigomha
Tutorial edits for refs, syntax, add typeof
171b580
kdayday and others added 17 commits January 17, 2025 16:22
@kdayday @rodrigomha
Run formatter
8f7d58f
@kdayday @github-actions @rodrigomha
Update docs/src/tutorials/manipulating_datasets.md
8916875 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@daniel-thom @rodrigomha
Fix bug in convert_component
6902e51 
This bug caused a converted/copied component to have references to
system objects.
@jd-lara @rodrigomha
Update Project.toml
642bf8a
@GabrielKS @rodrigomha
Add fast_deepcopy_system function, fix NREL-Sienna#1233
6c43e94 
Closes NREL-Sienna#1231, closes NREL-Sienna#1233.
@GabrielKS @rodrigomha
fast_deepcopy_system: fix shared units references bug
b37b320
@GabrielKS @rodrigomha
Fix lingering compare_values bug
0f108e1
@daniel-thom @rodrigomha
SQL transactions for time series and supplemental attributes
4cb37a6
@daniel-thom @rodrigomha
Fix bugs and add test
dd80160
@daniel-thom @rodrigomha
Update docs
a2a1fc8
@daniel-thom @rodrigomha
Fix spelling of function
ce3617d
@kdayday @rodrigomha
Move tutorial order
2c4f750
@kdayday @rodrigomha
Finalize tutorial links
166742f
@kdayday @rodrigomha
Run formatter
f9634c1
@rodrigomha
Merge branch 'psy5' into 3WTransformer
71ec732
@mcllerena
create ext dictionary to save data
b50917f
@mcllerena
add gen extra parameters on ext dict
a184a82
@mcllerena mcllerena requested a review from GabrielKS January 29, 2025 18:56
GabrielKS
GabrielKS requested changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a version of this PR that only includes the relevant commits? If this gets merged it merges a lot of stuff besides just adding those parameters.

@mcllerena mcllerena closed this Jan 29, 2025
@mcllerena mcllerena deleted the add_gen_ext_dict branch January 29, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielKS GabrielKS GabrielKS requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mcllerena @GabrielKS @rodrigomha @annacasavant @kdayday @daniel-thom @jd-lara