Add LCC and VSC models with PSS/E Parser #1267
Conversation
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: mcllerena <[email protected]>
src/PowerSystems.jl
Outdated
| @@ -34,7 +34,8 @@ export Line | |||
| export MonitoredLine | |||
| export DCBranch | |||
| export TwoTerminalHVDCLine | |||
There was a problem hiding this comment.
| export TwoTerminalHVDCLine | |
| export TwoTerminalGenericHVDCLine |
| function make_dcline(name::String, d::Dict, bus_f::ACBus, bus_t::ACBus) | ||
| return TwoTerminalHVDCLine(; | ||
| function make_dcline(name::String, d::Dict, bus_f::ACBus, bus_t::ACBus, source_type::String) | ||
| if source_type == "pti" |
There was a problem hiding this comment.
Could use Val to dispatch on source_type
There was a problem hiding this comment.
It's possible but an overkill IMO, so we should be fine
| active_power_flow = get(d, "pf", 0.0), | ||
| r = d["r"], | ||
| transfer_setpoint = d["transfer_setpoint"], | ||
| scheduled_dc_voltage = d["scheduled_dc_voltage"], |
There was a problem hiding this comment.
Could do some kwargs... splatting to streamline this arguments list
There was a problem hiding this comment.
... maybe next time?
| @@ -789,6 +789,7 @@ function read_dcline!( | |||
| bus_number_to_bus::Dict{Int, ACBus}; | |||
| kwargs..., | |||
| ) | |||
| # TODO: We should be able to get this PowerFlowData LCC lines working in future work. | |||
test/test_data/lcc_test.raw
Outdated
There was a problem hiding this comment.
I think this exists as two-terminal-hvdc_test.raw in PowerSystemsTestData, can we use that?
Co-authored-by: mcllerena <[email protected]>
Co-authored-by: <[email protected]>
Updated with the new name, and also added deprecation for older name so we don't need to update TestData or CaseBuilder for now. |
|
Tests are passing locally, but they are failing in some obscure I think we should merge to 3WTransformer, update everything there, and merge to psy5 asap. |
New PR that superseedes #1205. Too many conflicts with psy5 branch