PowerFlows.jl unified develop branch
#53
Draft
+3,954
−623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those sections being
Feature/nr_pf_solver
|
@GabrielKS bump PSY and PNM versions in this PR for the tests to pass |
Update dependencies
add field "converged" to PowerFlowData, return NaN when not converged
Done. Tests pass at #83 but tests will fail again here because #82 depends on NREL-Sienna/PowerNetworkMatrices.jl#95. |
Add fields to `PowerFlowEvaluationModel`s to support further PSI integration
GabrielKS
commented
Jan 27, 2025
src/psse_export.jl
Outdated
| SBASE = PSY.get_base_power(exporter.system) | ||
| REV = 33 | ||
| XFRRAT = 0 | ||
| NXFRAT = 1 # TODO why? |
There was a problem hiding this comment.
@jd-lara what should we have for this?
GabrielKS
commented
Jan 27, 2025
src/psse_export.jl
Outdated
| ZONE = PSSE_DEFAULT # defaults to zone's area | ||
| PL, QL, IP, IQ, YP, YQ = _psse_get_load_data(exporter, load) | ||
| OWNER = PSSE_DEFAULT # defaults to bus's owner | ||
| SCALE = PSSE_DEFAULT # TODO reconsider |
There was a problem hiding this comment.
@jd-lara should our loads be marked as scalable?
There was a problem hiding this comment.
no, we don't need that for our exporter/models
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+192
to
+193
| Yft = SparseArrays.sparse([1:length(fb); 1:length(fb)], [fb; tb], [y11; y12], length(fb), length(buses)) | ||
| Ytf = SparseArrays.sparse([1:length(tb); 1:length(tb)], [tb; fb], [y22; y21], length(tb), length(buses)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Yft = SparseArrays.sparse([1:length(fb); 1:length(fb)], [fb; tb], [y11; y12], length(fb), length(buses)) | |
| Ytf = SparseArrays.sparse([1:length(tb); 1:length(tb)], [tb; fb], [y22; y21], length(tb), length(buses)) | |
| Yft = SparseArrays.sparse( | |
| [1:length(fb); 1:length(fb)], | |
| [fb; tb], | |
| [y11; y12], | |
| length(fb), | |
| length(buses), | |
| ) | |
| Ytf = SparseArrays.sparse( | |
| [1:length(tb); 1:length(tb)], | |
| [tb; fb], | |
| [y22; y21], | |
| length(tb), | |
| length(buses), | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hrgks/psse_exporter_psy4branch has become a unifieddevelop-type branch for lots of new PowerFlows.jl functionality. It now contains the PSS/E exporter implementation as well as some new power flow implementations from @rbolgaryn. Pull requests include:PowerFlowDatafields for multi-period AC PF #78plus some more commits only in this branch.