model_choice.py: remove define_model() function #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 19, 2023 16:59
… if url default_multiclass.yaml: add checkpoint_dir param default_binary.yaml: idem model_choice.py: - remove load state dict path from define_model - read_checkpoint: set default "update=False", not True train_segmentation.py: adjust usage of define_model test_models.py: idem
inference_segmentation.py: refer directly to define_model_architecture() train_segmentation.py: idem test_models.py: idem
default_multiclass.yaml: idem
CharlesAuthier
approved these changes
Jan 23, 2023
ms888ekb
approved these changes
Jan 25, 2023
|
@valhassan mentionned that define_model() seems still useful in train_segmentation.py to handle model architecture definition and weight loading into a single function. Define_model() will live, for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460