-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.2.1 release candidate #97
Open
ceftanveer
wants to merge
129
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add set_scale to vfunc
improve tab writing
Renamed rst files
add fieldcalculator
add dtm file name
2107 obwb
* notes and catches * Added Lambda function for explict int typecasting * Removed debug code and comments * add some comments and remove a prints tatement * Code cleanup and added QmessageLog * fix the underscore import --------- Co-authored-by: Seth Bryant <[email protected]> Co-authored-by: Tanveer singh Bhatia <[email protected]>
* add pytest-qt to requirements for proper error catching --------- Co-authored-by: Tanveer singh Bhatia <[email protected]> Co-authored-by: Seth Bryant <[email protected]>
clean up some error catches on teh validation add openpyxl as the explicate engine --------- Co-authored-by: Tanveer singh Bhatia <[email protected]> Co-authored-by: Seth Bryant <[email protected]>
cefect
requested changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to close out all the errors first
* Fix for Box plot not coming up * Updated plots for model and build --------- Co-authored-by: Tanveer singh Bhatia <[email protected]>
closes issue * Updated control files with relative path, removed hardcoded path * Added logic to handle relative path --------- Co-authored-by: Tanveer singh Bhatia <[email protected]> Co-authored-by: Seth Bryant <[email protected]>
absolute_fp improper equals
remove not implemented check
pass absolute_fp
clean up docstrings
…ta-type 55 switch tutorial vector layer data type
* add test_build_rsamp_runPrep * Update 06_tutorials.rst
* absolute_fp checked while updating control file * updated control file for relative path * Removed unsed argument * Updated test to check relative paths * Added a test folder for second case (False) absolute_fp * update some comments * comments * Update test_tutorial_02.py * Updated Test and dmg file * Update CanFlood_control_01.txt spelling * comment and logging updates * clean up entry point and rename * add version tag to build ui * move definitions file * add test_sensi * test rfda * Create test_dikes.py * pythonpath import fix * fix version tag * Create CanFlood - tutorial 2.qgz * plugin setup working directory to cf_fp --------- Co-authored-by: Tanveer singh Bhatia <[email protected]> Co-authored-by: Seth Bryant <[email protected]>
* Web connections proof of concept * Updated with relative paths instead of hardcoded path * Added arcgis, wms and wcs connections * replaced print statement with proper error * Added test for Web connections * Removed unused ini file path * Updated test to ensure ini files updated to pass test * Update test_webconnections.py rename * Refactored test code * Update test_webconnections.py * update gitignore * Update webConnections.py * Removed the non working links --------- Co-authored-by: Tanveer singh Bhatia <[email protected]> Co-authored-by: Seth Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
pull changes from master into dev branch (should just be small changes to .md files)
update the documentation if necessary.
ensure the documentation builds are passing on ReadTheDocs
update the QGIS and CanFlood version tag on build.ui and the project README.md.
update the Updates section of the project README.md.
similarly update plugin metadata file
update the plugin requirements file to capture the exact dependencies (pip freeze)
execute all pytests. investigate warnings. fix errors. (ctrl+f in console for 'error' and 'warning' as a workaround)
use plug_zip.bat to create the plugin zip (canflood.zip) installable version of the release candidate in ./plugin_zips
perform a person test by having a non-developer follow relevant tutorials. investigate warnings and fix errors.