Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dependencies to the Java Library Gradle plugin #314

Merged
merged 2 commits into from
Mar 19, 2018

Conversation

ExE-Boss
Copy link
Member

This migrates the dependencies of NOVA-Core to use the Java Library Plugin (see #313).

@ExE-Boss ExE-Boss added enhancement Nice to have features done Pull requests that are finished and are ready to be reviewed and merged labels Mar 19, 2018
@ExE-Boss ExE-Boss added this to the v0.1.0 milestone Mar 19, 2018
@ExE-Boss ExE-Boss self-assigned this Mar 19, 2018
@ExE-Boss ExE-Boss added in progress Pull requests that are not yet ready to be merged and issues that are being worked on. and removed done Pull requests that are finished and are ready to be reviewed and merged labels Mar 19, 2018
RX14
RX14 previously approved these changes Mar 19, 2018
@RX14 RX14 dismissed their stale review March 19, 2018 13:32

Something broke the CI :(

@ExE-Boss
Copy link
Member Author

It’s because java-library requires Gradle 3+, but ForgeGradle 1.2 is incompatible with Gradle 4+.

@ExE-Boss ExE-Boss added done Pull requests that are finished and are ready to be reviewed and merged and removed in progress Pull requests that are not yet ready to be merged and issues that are being worked on. labels Mar 19, 2018
@codecov-io
Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #314   +/-   ##
=========================================
  Coverage     16.99%   16.99%           
  Complexity      965      965           
=========================================
  Files           416      416           
  Lines         13165    13165           
  Branches       1383     1383           
=========================================
  Hits           2237     2237           
  Misses        10782    10782           
  Partials        146      146
Impacted Files Coverage Δ Complexity Δ
src/main/java/nova/core/util/registry/Factory.java 48.14% <ø> (ø) 5 <0> (ø) ⬇️
...rc/main/java/nova/core/component/ComponentMap.java 54.05% <ø> (ø) 10 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297857e...84cb535. Read the comment docs.

@RX14
Copy link
Contributor

RX14 commented Mar 19, 2018

Would be nice if you had time to work on the actual code instead of just mess with gradle :)

@ExE-Boss ExE-Boss deleted the gradle/plugin/java-library branch March 19, 2018 13:44
@ExE-Boss
Copy link
Member Author

I have been working on the refactor/inventory branch, but that required this, NOVA-Team/NOVA-Gradle#16 and NOVA-Team/NOVA-Gradle#17 to be merged because of the ForgeGradle issues.

@RX14
Copy link
Contributor

RX14 commented Mar 19, 2018

Oh cool, nice to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Pull requests that are finished and are ready to be reviewed and merged enhancement Nice to have features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants