Avoid relying on non-standard Fortran syntax extension for unary negation #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion The code as written leads gfortran to produce this warning: > Warning: Extension: Unary operator following arithmetic operator (use parentheses)
|
Many of the cases touched in my change could maybe be more clearly rewritten by replacing addition with subtraction, or reciprocal by exponentiation with division. I opted to take a purely syntactic approach. I'll defer to the Noah developers on how they'd like arithmetic to be written out in the code. |
GreyREvenson
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code as written leads gfortran to produce this warning: