Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update objectives.py so uses kge instead of 1-kge #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update objectives.py so uses kge instead of 1-kge #89

wants to merge 1 commit into from

Commits on Jan 2, 2024

  1. Update objectives.py so uses kge instead of 1-kge 

    I think as an artifact of previous times when all optimization was done via minimization, if a user wanted to optimize using 'kling_gupta', they would have to specify 'min' as target. This is completely counterintuitive since kge should be maxmized (-inf<kge<=1 and kge=1 is best possible score). By using kge direclty, the user can intuitively set the target as 'max'.
    @Ben-Choat
    Ben-Choat committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    fba20f5 View commit details
    Browse the repository at this point in the history