[1pt]: PR: Reload 3dep DEMs and pre-clips #1301
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reload of all 3Dep DEMs from USGS was performed to refresh our data.
acquire_and_preprocess_3dep_dems.py
had to be run twice, one for Alaska and once for the rest to two different folder. This is due to different CRS's. Eventually, we could merge these into one run. This also meant two separate vrt runs / files.This also triggered a new set of pre-clips for both AK and CONUS+ but the outputs can/were put into the same folder, so fim_pipeline looks in one common pre-clip folder.
Other minor adjustment include:
rating_curve_comparions.py
. This was added as it is expected to be used soon for a full BED/Production. The fix focuses purely on duration, but a test did detect a possible pre-existing logic problem. A separate card will be created for that.Note:
The root folder for DEM is being changed from:
/inputs/3dep_dems/.... to
/inputs/dems/3dep_dems/....
This recognizes other DEMs that may be coming in the near future.
The same sub-folder patterns have not be changed.
No attempts will be made at this time to move older files, only new incoming from this PR.
Changes
CITATION.cff
: has not be updated for a very long time.fim_post_processing.sh
: Update to file/folder permissions.data
wbd
generate_pre_clip_from_huc8.py
:preprocess_wbd.py
src\base_variables.env
: Changes to variables to reflect new dems and pre-clip paths.tools\rating_curve_comparisons.py
Testing
Deployment Plan (For developer use)
Files/folders to be copied to other enviros
From: /efs..../inputs/dems
From: /efs.../inputs/pre_clip_huc8/20240917/
Copy to:
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)