-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] PR: Change Docker base image and stop Whitebox downloads #1291
base: dev
Are you sure you want to change the base?
Conversation
The Docker fix has been tested. Removed all images from our OWP "u" servers, had ITSG check to make sure there was no residue. Then loaded our new container from here and ITSG said it was still fixed. So we are good to go on the docker base image fix |
built the image on one of my EC2's, then ran sudo find /var/lib/docker/ -type f -name "java-17" to ensure it didn't pop back up. All good on that part. Doing a pipeline test next. |
Tested the new changes by building a new Docker image and running fim_pipeline, synthesize_test_cases, and eval_plots. Verified no import error and the eval plots were created successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matt and I went back and forth on testing and validate. All is well now
Note: the message |
This PR incorporates a number of changes to the Docker environment:
gdal:ubuntu-small
in order to avoid JDK from being carried over in the base image and triggering security vulnerabilities. Resolves [8pt] Open JDK 17 re-appeared #1278.fiona
andjupterlab
. Closes Bump jupyterlab from 3.6.7 to 3.6.8 #1270 and closes Bump fiona from 1.9.6 to 1.10.0 #1290.whitebox
downloading duringfim_pipeline
. Resolves [8pt] Whitebox calling URL at runtime #1209 and closes [1pt] PR: Stop Whitebox from downloading during runtime #1293.During testing, it was discovered that many files which are not in the
src
directory, can no longer see thesrc\utils
files. Adjusting the dockerfile to add extra values to the PYTHONPATH variable fixed it.Note: This triggers new docker images to be made.
Changes
Dockerfile
: Changes base image togdal:ubuntu-small-3.8.4
and removes code related to JDKPipfile
andPipfile.lock
: Upgradesfiona
,jupyterlab
, andwhitebox
fim_pre_processing
: RemovesWBT_PATH
assignmentsrc/
agreedem.py
andunique_pixel_and_allocation.py
: setswhitebox_dir
toWBT_PATH
Testing
Ran
fim_pipeline.sh
andsynthesize_test_cases.py
on HUC 03100204.Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)