Use shapely objects to store geometries. #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_schism_fim uses a lot of memory. I tested with the pacific domain and discovered that loading the shapefile into memory takes almost 3GB of RAM.
Fiona represents geometries as dictionaries of objects. When storing large geometries such as those in the pacific domain, it becomes very inefficient. Fortunately, we can store geometries as shapely objects, which only use a fraction of the memory.
Before/after memory usage of
get_mask_geoms_by_group
Other misc fixes are removing two ineffective gc calls and an unnecessary enumeration.