RNR Hotfix: Workflow modified to save and reassign status rather than recalculate #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a number of issues reported by WPOD
|
Nice. I know you were hesitant about how deferring to the status columns could mask the data issues with thresholds... but this seems like a good approach to propagate the RFC-assigned statuses without compromising the integrity of the data model that you've setup in your new and improved RnR workflow. |
nickchadwick-noaa
approved these changes
Jan 3, 2024
nickchadwick-noaa
pushed a commit
that referenced
this pull request
Feb 21, 2024
… recalculate (#603) The RFC 5-Day Max Downstream Streamflow service was completely recalculating its status based on comparing the output RnR flows to streamflow thresholds where available. Because streamflow thresholds are not available for every site, certain sites were not able to be categorized. This is silly since the flood status of every relevant point is already pre-calculated as the starting point for the RnR WRF-Hydro inputs. Thus, this fix writes those statuses to the db during pre-processing and then joins to that table to re-assign the status at post-processing. These changes fix a number of issues reported by WPOD: https://vlab.noaa.gov/redmine/issues/124216 https://vlab.noaa.gov/redmine/issues/124212 https://vlab.noaa.gov/redmine/issues/124202 https://vlab.noaa.gov/redmine/issues/124165 The changes herein were hotfixed in-place, manually, on Production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC 5-Day Max Downstream Streamflow service was completely recalculating its status based on comparing the output RnR flows to streamflow thresholds where available. Because streamflow thresholds are not available for every site, certain sites were not able to be categorized. This is silly since the flood status of every relevant point is already pre-calculated as the starting point for the RnR WRF-Hydro inputs. Thus, this fix writes those statuses to the db during pre-processing and then joins to that table to re-assign the status at post-processing.
These changes fix a number of issues reported by WPOD:
https://vlab.noaa.gov/redmine/issues/124216
https://vlab.noaa.gov/redmine/issues/124212
https://vlab.noaa.gov/redmine/issues/124202
https://vlab.noaa.gov/redmine/issues/124165
The changes herein were hotfixed in-place, manually, on Production.