-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viz EC2 Services to Lambda - Part 2 - Rapid Onset Flooding Probability #558
Conversation
…processing lambda function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerSchrag-NOAA can you double check the HWP file changes in all these files? I think there might be some issues with the table references and whether or not the "max" is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in the product is creating a "mrf_gfs_5day_high_water_probability_hucs" table but the mapx is looking for a "mrf_gfs_5day_max_high_water_probability_hucs"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I missed/botched this one somehow. Thank you!
removed HWP services from the pipelines_config.yml so that the EC2 doesn't create windows services for them to run
@TylerSchrag-NOAA I also updated the pipeline_config file which is used by the EC2 to create the windows services |
Thank you! I totally missed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Thanks Shawn - Sorry to make you approve again, but I just realized I forgot to add the new dask lambda layer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, the dask layer. Now it looks better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
#558) This PR migrates the ensemble-based Rapid Onset Flooding Probability products from the Viz EC2 to the Viz Max Values lambda function (now called Python Preprocessing). It broadly encapsulates the following changes: **Changes** - New rapid_onset_flooding product script in the python_preprocessing lambda function that supports both 12 hour SRF and 5 day GFS MRF configurations. - Removal of rapid_onset_flooding pipeline and product files in the source-aws_loosa library **Deployment Considerations:** - Not sure if we should include this in the 2.1.4 release or not? I'm good to test/fix quickly and thoroughly next week if you want to include it. Otherwise, fine to go in the next one (wait to merge for now) - We will need to include a ingest schema db dump when deploying to UAT. --------- Co-authored-by: CoreyKrewson-NOAA <[email protected]>
This PR migrates the ensemble-based Rapid Onset Flooding Probability products from the Viz EC2 to the Viz Max Values lambda function (now called Python Preprocessing). It broadly encapsulates the following changes:
Changes
Deployment Considerations: