Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz EC2 Services to Lambda - Part 2 - Rapid Onset Flooding Probability #558

Merged
merged 18 commits into from
Dec 12, 2023

Conversation

TylerSchrag-NOAA
Copy link
Contributor

@TylerSchrag-NOAA TylerSchrag-NOAA commented Oct 5, 2023

This PR migrates the ensemble-based Rapid Onset Flooding Probability products from the Viz EC2 to the Viz Max Values lambda function (now called Python Preprocessing). It broadly encapsulates the following changes:

Changes

  • New rapid_onset_flooding product script in the python_preprocessing lambda function that supports both 12 hour SRF and 5 day GFS MRF configurations.
  • Removal of rapid_onset_flooding pipeline and product files in the source-aws_loosa library

Deployment Considerations:

  • Not sure if we should include this in the 2.1.4 release or not? I'm good to test/fix quickly and thoroughly next week if you want to include it. Otherwise, fine to go in the next one (wait to merge for now)
  • We will need to include a ingest schema db dump when deploying to UAT.

@TylerSchrag-NOAA TylerSchrag-NOAA added the enhancement New feature or request label Oct 5, 2023
@TylerSchrag-NOAA TylerSchrag-NOAA changed the title Viz EC2 Services to Lambda - Part 2 - Rapid Onset Flooding Viz EC2 Services to Lambda - Part 2 - Rapid Onset Flooding Probability Oct 5, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerSchrag-NOAA can you double check the HWP file changes in all these files? I think there might be some issues with the table references and whether or not the "max" is there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in the product is creating a "mrf_gfs_5day_high_water_probability_hucs" table but the mapx is looking for a "mrf_gfs_5day_max_high_water_probability_hucs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I missed/botched this one somehow. Thank you!

removed HWP services from the pipelines_config.yml so that the EC2 doesn't create windows services for them to run
@CoreyKrewson-NOAA
Copy link
Contributor

@TylerSchrag-NOAA I also updated the pipeline_config file which is used by the EC2 to create the windows services

@CoreyKrewson-NOAA CoreyKrewson-NOAA added this to the V2.1.4 milestone Oct 6, 2023
@TylerSchrag-NOAA
Copy link
Contributor Author

@TylerSchrag-NOAA I also updated the pipeline_config file which is used by the EC2 to create the windows services

Thank you! I totally missed that.

shawncrawley
shawncrawley previously approved these changes Oct 10, 2023
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@TylerSchrag-NOAA
Copy link
Contributor Author

This looks good to me!

Thanks Shawn - Sorry to make you approve again, but I just realized I forgot to add the new dask lambda layer.

shawncrawley
shawncrawley previously approved these changes Oct 10, 2023
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, the dask layer. Now it looks better.

@TylerSchrag-NOAA TylerSchrag-NOAA self-assigned this Oct 17, 2023
@TylerSchrag-NOAA TylerSchrag-NOAA modified the milestones: V2.1.4, V2.1.5 Oct 17, 2023
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@nickchadwick-noaa nickchadwick-noaa merged commit 493f5f9 into ti Dec 12, 2023
1 check passed
@nickchadwick-noaa nickchadwick-noaa deleted the viz_ec2_services_to_lambda_part2 branch December 12, 2023 19:09
nickchadwick-noaa pushed a commit that referenced this pull request Feb 21, 2024
#558)

This PR migrates the ensemble-based Rapid Onset Flooding Probability
products from the Viz EC2 to the Viz Max Values lambda function (now
called Python Preprocessing). It broadly encapsulates the following
changes:

**Changes**
- New rapid_onset_flooding product script in the python_preprocessing
lambda function that supports both 12 hour SRF and 5 day GFS MRF
configurations.
- Removal of rapid_onset_flooding pipeline and product files in the
source-aws_loosa library

**Deployment Considerations:**
- Not sure if we should include this in the 2.1.4 release or not? I'm
good to test/fix quickly and thoroughly next week if you want to include
it. Otherwise, fine to go in the next one (wait to merge for now)
- We will need to include a ingest schema db dump when deploying to UAT.

---------

Co-authored-by: CoreyKrewson-NOAA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants