Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm noaa:monitoring allowing granular env setting #1002

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

EdisonOrellana-NOAA
Copy link
Contributor

  • This removes setting the "noaa:monitoring": "true" from four terraform files.
  • The monitoring setting should only be on for prod.
  • This tag is applied individually for prod in both regions in the env yaml files on the vlab repo instead of here
  • If monitoring stops working, this change could be why

Copy link
Collaborator

@DrixTabligan-NOAA DrixTabligan-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove the whole block. This will leave it empty which will error out.

@RobHanna-NOAA
Copy link
Contributor

oh good to know. We put in monitoring as False. We will remove it from ours too. @CarsonPruitt-NOAA : Can you take care of this for our current EC2's? I will take it out the scripts for new EC2 finalization.

@DrixTabligan-NOAA
Copy link
Collaborator

DrixTabligan-NOAA commented Nov 27, 2024 via email

@RobHanna-NOAA
Copy link
Contributor

oh good to know. We put in monitoring as False. We will remove it from ours too. @CarsonPruitt-NOAA : Can you take care of this for our current EC2's? I will take it out the scripts for new EC2 finalization.

Oops.. I am a dork.. we left it out already :), so we are good

Copy link
Collaborator

@DrixTabligan-NOAA DrixTabligan-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will merge.

@DrixTabligan-NOAA DrixTabligan-NOAA merged commit e14d76b into ti Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants