Evaluation Service REST conversion #435
Conversation
There was a problem hiding this comment.
I left a few minor comments that should be pretty easy to get through. Thanks, @christophertubbs!
python/services/evaluationservice/dmod/evaluationservice/evaluation_service/messages/base.py
Show resolved
Hide resolved
python/services/evaluationservice/dmod/evaluationservice/evaluation_service/specification.py
Show resolved
Hide resolved
| query_parameters["template_name__icontains"] = name | ||
|
|
||
| if author: | ||
| query_parameters['author__username__icontains'] = author |
There was a problem hiding this comment.
Assuming this is the correct number of underscores? It just looked a little different than the others.
| password = password.decode() | ||
|
|
||
| username_and_password = f"{username}:{password}".encode() | ||
| return {"HTTP_AUTHORIZATION": f"Basic {base64.b64encode(username_and_password).decode()}"} |
There was a problem hiding this comment.
It might be worth adding a comment here noting that this is a django specific keyword argument that gets turned into an Authorization header.
There was a problem hiding this comment.
This looks good to me! Thanks for working through this with me, @christophertubbs!
|
@christophertubbs, is this just waiting on resolving the conflicts with recent changes? |
|
THIS HASN'T BEEN MERGED?! Oof, yeah, it needs resolved. Let me jump through all that. This needs to be in there asap. |
…emoved in the future
…wn message types and added unit tests ensuring that they behave as intended
…d updated Dataset to make it serializable
christophertubbs
force-pushed
the
evaluation-frontend
branch
from
4255f1b to
c42f2ae
Compare
|
Didn't we just deal with something else causing failures like this in another issue? Any chance the rebase didn't quite get everything in the latest master? |
…ed an issue where django tests weren't correctly building output, restored some type hinting on an enum, and fixed some merge errors
|
Fixed. Someone please review and merge it before it becomes out of date again. |
Created copies of CRUD calls that were going through websockets that instead go through GET and POST requests.
This includes formal messages and new views.
Prototypes for the next.js interface are along for the ride.