Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] adds bucket code for 15 minute QPF, cleans up legacy makefiles #69

Merged

Conversation

MatthewPyle-NOAA
Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA commented May 31, 2024

DESCRIPTION OF CHANGES:

Adds new rrfs_bucket.fd code. It probably isn't in final form, but want to get it established within rrfs_utl. Also cleaned out some legacy makefiles from the pre-cmake build system for the bufrsnd codes.

TESTS CONDUCTED:

Confirmed that it all builds, and confirmed that the rrfs_bucket executable built from this rrfs_utl could run a simple offline test script of the bucket processing.

DEPENDENCIES:

DOCUMENTATION:

ISSUE (optional):

Partially resolves this issue.

CONTRIBUTORS (optional):

Copy link
Collaborator

@christopherwharrop-noaa christopherwharrop-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update and especially for removing the obsolete makefiles. My only request is in regards to the bucket_diff.f file being added. The coding style does not incorporate proper indentation for conditionals and loops and is very inconsistent throughout. As a result the code is very hard to read and understand.
Since this is a new addition, it would be nice to have that cleaned up at the start. Could you please add consistent indentation for that new code?

@MatthewPyle-NOAA
Copy link
Contributor Author

@christopherwharrop-noaa Good suggestion - did some formatting cleanup. Let me know if that wasn't enough.

Copy link
Collaborator

@christopherwharrop-noaa christopherwharrop-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for fixing the indentation. That is a huge improvement that makes the code a lot easier to look at.

@MatthewPyle-NOAA
Copy link
Contributor Author

Will have another commit for this one - my updated code had an error preventing it from compiling. Once I confirm that this problem is resolved, will push another change.

@hu5970 hu5970 merged commit a1608a8 into NOAA-GSL:production/RRFS.v1 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants