Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build script for intel oneapi and gcc compiler separately #88

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

xyuan
Copy link

@xyuan xyuan commented Jun 17, 2024

Description
add build env script for intel oneAPI build and gcc build of Pace with optimization options for loop unroll, and array prefetch.

please note that these options are needed to be incorported in the regression test and container build, with the purpose of supporting various supercomputers in the future.

Fixes # (issue)
If this is a hotfix to a released version, please specify it.

How Has This Been Tested?
The options for Intel compiler are tested using
Intel(R) oneAPI DPC++/C++ Compiler for applications running on Intel(R) 64, Version 2024.1.0 Build 20240308

and the gcc compiler was tesed using
gcc 13.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Contributor

@fmalatino fmalatino Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions:

  • Do we want to continue to suport python 3.8?
  • Should we allow the user to pass the desired name for the conda environment to be used, or do we want to keep it as my_name in general?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, let me test python 3.11.9, and update the script

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck
Copy link
Collaborator

This requires a new GT4Py

@fmalatino
Copy link
Contributor

This requires a new GT4Py

@xyuan Does this PR depend on your PR 1552 in GT4Py?

@xyuan
Copy link
Author

xyuan commented Jun 17, 2024

This requires a new GT4Py

@xyuan Does this PR depend on your PR 1552 in GT4Py?

yes, but it is still safe to merge it to pace

Copy link
Contributor

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small q about the python module import on C5, otherwise LGTM

module rm gcc
module load gcc/12.2.0
module load boost/1.79.0
module load python/3.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the python version here too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, updated to the python 3.11.7

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending changes to examples/build_scripts/build_gaea_c5_gcc.sh to update python version to 3.11

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino requested a review from oelbert July 9, 2024 18:51
Copy link
Contributor

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the gt4py version is ok we're 👍

@fmalatino fmalatino merged commit 4e2521d into develop Jul 10, 2024
2 checks passed
@xyuan xyuan deleted the xyuan/compiler branch July 16, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants