Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regrid xy #199

Merged
merged 51 commits into from
Oct 3, 2024
Merged

Add regrid xy #199

merged 51 commits into from
Oct 3, 2024

Conversation

ilaflott
Copy link
Member

@ilaflott ilaflott commented Oct 1, 2024 •
edited
Loading

inspired by NOAA-GFDL/fre-workflows#32

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@ilaflott
make fre app regrid a click command
c341038
@ilaflott
inital cli pytests for fre app calls
04b856a
@ilaflott
add c96 mosaic, its only 4 KB
36f6de7
@ilaflott
adjust input test directory
9639a68
@ilaflott
keep conda env test simpler for now
56ecc96
@ilaflott
stop build_conda for now to stop needless cpu usage for tricky test c…
4532869 
…ase logistics (test data filesize again...)
@ilaflott
thank you past-me for putting in a CLEAN_ALL_OUTPUT flag to turn off …
3576aa7 
…bad behavior....
@ilaflott
fix import in test script
64bd5f2
@ilaflott
add atmos_static_cmip data
355f18e
@ilaflott
add in more negligibly small test files on the order of a few dozen kb
a88fc21
@ilaflott
quick assert sanity check
e0bc4f0
@ilaflott
fix path
e975e40
@ilaflott
more smol test data
ce92637
@ilaflott
adjust test to use imported regrid_xy module
332f6de
@ilaflott
change up error-catching case on wrong date-time. rose-app-run.conf f…
8285d18 
…udging in tests.
@ilaflott
turn off clean work flag
016ec00
@ilaflott
add another itty-bitty-smol-meatball of test data. last one i hope! s…
ee0871d 
…pecify input mosaic file directly instead of tar file archive
@ilaflott
actually have all significant work taking place in work directory... …
9d93aa1 
…cleaner yay. now have no-tar-file and tar-file cases for grid_spec targeting. @ceblanton might need your help with pathlib paths
@ilaflott
pass tar test on pipeline if the golden grid spec tar-file is not fou…
2446550 
…nd... this will only work at gfdl for now.
@ilaflott
put back on exit-on-first-failure
b200826
@ilaflott
forgive me, good-practitioners of git, for i have sinned
5a030ce
@ilaflott
getting there....
85063f6
@ilaflott
.... lets see
e003dbb
@ilaflott
ALMOST. THERE. BLARGH.
499c486
@ilaflott
ALMOST. THERE. BLARGH2.
6f033f7
@ilaflott
.... so close...
47ddc11
@ilaflott
Merge branch 'main' into add_regrid_xy
11316b5
@ilaflott
taking off the gloves...
43de5e2
@ilaflott ilaflott marked this pull request as ready for review October 2, 2024 20:54
ceblanton
ceblanton approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Does it really work as-is even with the Rose config usage?

singhd789
singhd789 reviewed Oct 3, 2024
View reviewed changes
fre/app/freapp.py Outdated Show resolved Hide resolved
fre/app/freapp.py Outdated Show resolved Hide resolved
fre/app/freapp.py Outdated Show resolved Hide resolved
fre/app/freapp.py Outdated Show resolved Hide resolved
fre/app/freapp.py Show resolved Hide resolved
fre/app/freapp.py Show resolved Hide resolved
fre/app/freapp.py Show resolved Hide resolved
fre/app/freapp.py Show resolved Hide resolved
singhd789
singhd789 reviewed Oct 3, 2024
View reviewed changes
fre/make/createCompile.py Show resolved Hide resolved
fre/make/createDocker.py Show resolved Hide resolved
@ilaflott ilaflott merged commit f5b67d1 into main Oct 3, 2024
2 checks passed
@ilaflott ilaflott deleted the add_regrid_xy branch October 3, 2024 20:24
@ilaflott ilaflott mentioned this pull request Oct 4, 2024
Open
@ilaflott ilaflott linked an issue Oct 7, 2024 that may be closed by this pull request
Absorb fre-workflows/app/regrid-xy --> fre pp regrid #132
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhd789 singhd789 singhd789 left review comments

@ceblanton ceblanton ceblanton approved these changes

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Absorb fre-workflows/app/regrid-xy --> fre pp regrid
3 participants
@ilaflott @ceblanton @singhd789