Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/wfc/restart ensemblename fix #562

Merged

Conversation

wfcooke
Copy link

@wfcooke wfcooke commented Feb 1, 2024

This should fix
#485

Fix issue with restart filenames when using ensembles.

Moved call for filename_appendix outside of loop.

Fixes issue where restart filename was
./MOM.res.ens_01.nc
./MOM.res.ens_01.ens_01_1.nc
./MOM.res.ens_01.ens_01.ens_01_2.nc
./MOM.res.ens_01.ens_01.ens_01.ens_01_3.nc

instead of
./MOM.res.ens_01.nc
./MOM.res.ens_01_1.nc
./MOM.res.ens_01_2.nc
./MOM.res.ens_01_3.nc

wfcooke and others added 3 commits September 6, 2019 10:10
Updating dev/gfdl to Aug 30th 2019
Moved call for filename_appendix outside of loop.

Fixes issue where restart filename was
./MOM.res.ens_01.nc
./MOM.res.ens_01.ens_01_1.nc
./MOM.res.ens_01.ens_01.ens_01_2.nc
./MOM.res.ens_01.ens_01.ens_01.ens_01_3.nc

instead of
./MOM.res.ens_01.nc
./MOM.res.ens_01_1.nc
./MOM.res.ens_01_2.nc
./MOM.res.ens_01_3.nc
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9a6ddee) 37.21% compared to head (d8bc812) 37.21%.

Files Patch % Lines
src/framework/MOM_restart.F90 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           dev/gfdl     #562   +/-   ##
=========================================
  Coverage     37.21%   37.21%           
=========================================
  Files           271      271           
  Lines         80430    80430           
  Branches      14995    14995           
=========================================
  Hits          29930    29930           
  Misses        44937    44937           
  Partials       5563     5563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, and I understand how they would have corrected the bug described in issue #485.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22250 ✔️

@marshallward marshallward merged commit ea12532 into NOAA-GFDL:dev/gfdl Feb 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants