Revert post_data fix to CFC concentration #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent NCAR -> GFDL merge created an error (courtesy of myself) which left the CFC concentration units in the post_data call, even though these are now handled at registration. This patch restores this expression and removes the unit conversion from post_data.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-gfdl-main-candidate-2023-11-13 #521 +/- ##
======================================================================
- Coverage 37.46% 37.45% -0.01%
======================================================================
Files 270 270
Lines 79763 79763
Branches 14830 14830
======================================================================
- Hits 29880 29879 -1
Misses 44349 44349
- Partials 5534 5535 +1 ☔ View full report in Codecov by Sentry. |
|
@klindsay28 Can you have a quick look? |
|
LGTM. Thanks for the quick response. |
|
Thanks @klindsay28, I still do not know a good way to submit conflict fixes for review and for the most part I end up pushing them in myself. |
adcroft
approved these changes
Nov 15, 2023
marshallward
merged commit f4c95ec
into
NOAA-GFDL:dev-gfdl-main-candidate-2023-11-13
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent NCAR -> GFDL merge created an error (courtesy of myself) which left the CFC concentration units in the post_data call, even though these are now handled at registration.
This patch restores this expression and removes the unit conversion from post_data.