*Use thickness_to_dz in dumbbell_initialize_sponges

[Hallberg-NOAA]

Use thickness_to_dz to convert thicknesses from thickness units to height units in dumbbell_initialize_sponges with the traditional (non-ALE) sponges. Boussinesq answers are identical, but non-Boussinesq answers with an equation of state will change to be less dependent on the value of RHO_0.

[codecov]

Codecov Report

Merging #487 (8ec493f) into dev/gfdl (2ac48a6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 8ec493f differs from pull request most recent head 4c78dbd. Consider uploading reports for the commit 4c78dbd to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #487      +/-   ##
============================================
- Coverage     37.80%   37.79%   -0.01%     
============================================
  Files           270      270              
  Lines         78403    78404       +1     
  Branches      14521    14521              
============================================
- Hits          29638    29636       -2     
- Misses        43361    43364       +3     
  Partials       5404     5404              

Files	Coverage Δ
src/user/dumbbell_initialization.F90	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[marshallward]

Seems to be a CI error:

ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: WARNING from PE     0: fms_io(restore_state_all): unable to find any restart files specified by INPUT/ice_ocmip2_cfc.res.nc
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: WARNING from PE     0: fms_io(restore_state_all): unable to find any restart files specified by INPUT/ice_ocmip2_cfc.res.nc
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: WARNING from PE     0: fms_io(restore_state_all): unable to find any restart files specified by INPUT/ice_ocmip2_cfc.res.nc
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: Program received signal SIGSEGV: Segmentation fault - invalid memory reference.
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: Backtrace for this error:
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #0  0x7ff1d3e8fdbf in ???
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #1  0xc42f5e in tracer_epipycnal_ml_diff
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: 	at ../../../../.././/src/MOM6/src/tracer/MOM_tracer_hor_diff.F90:1187
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #2  0xc50c72 in __mom_tracer_hor_diff_MOD_tracer_hordiff
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: 	at ../../../../.././/src/MOM6/src/tracer/MOM_tracer_hor_diff.F90:536
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #3  0x9bd645 in step_mom_tracer_dyn
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: 	at ../../../../.././/src/MOM6/src/core/MOM.F90:1408
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #4  0x9c469d in __mom_MOD_step_mom
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: 	at ../../../../.././/src/MOM6/src/core/MOM.F90:910
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #5  0x8cc1b8 in __ocean_model_mod_MOD_update_ocean_model
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: 	at ../../../../.././/src/MOM6/config_src/drivers/FMS_cap/ocean_model_MOM.F90:594
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #6  0x47dabd in coupler_main
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: 	at ../../../../.././/src/coupler/coupler_main.F90:1083
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: #7  0x48abf6 in main
ice_ocean_SIS2/SIS2_cgrid/ocean.stats.gnu: 	at ../../../../.././/src/coupler/coupler_main.F90:313

[marshallward]

The error mentioned above must be unrelated, I will look into what might have happened.

[marshallward]

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20904 ✔️

Maybe that error was MPI-related. Apologies for not looking at it more closely.