-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial submodule (TempestExtremes) support #526
initial submodule (TempestExtremes) support #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change request for module_config template. Would it be possible to add a module_config yaml template as well?
templates/module_config.jsonc
Outdated
"conda_root": "/home/jacob.mims/miniconda3", | ||
|
||
// Directory containing the framework-specific conda environments. This should | ||
// be equal to the "--env_dir" flag passed to conda_env_setup.sh. If left | ||
// blank, the framework will look for its environments in conda_root/envs | ||
//"conda_env_root": "/net/jml/miniconda3/envs", | ||
"conda_env_root": "/home/jacob.mims/miniconda3/envs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove home directories from template
Description
Adds initial support for launching submodules (e.g. TempestExtremes) that have a python wrapper. It also adds an example json file on how to define what functions one would like to call from the submodule.
Associated issue #516
How Has This Been Tested?
This was built using the entire MDTF on my thin client and demoed to @wrongkindofdoctor, while the TempestExtremes wrapper was built and ran on both my thin client and PPAN.
Checklist:
conda_env_setup.sh