STY: Use mbar and Pa for units of pressure #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should keep my unit software from thinking I measure pressure in picoannum
My unit software thinks the latter is millibarn, a unit of area for atomic scattering. This may help with CF compliance.
My unit software reads "pa" as "picoannum", a unit of time on the order of microseconds, rather than as "pascals", the unit of pressure.
This was referenced Aug 9, 2024
|
Can you please resolve the conflicts in the file |
XiaqiongZhou-NOAA
approved these changes
Aug 23, 2024
bensonr
approved these changes
Sep 6, 2024
This was referenced Oct 11, 2024
14 tasks
|
All test is done at ufs-community/ufs-weather-model#2475. @laurenchilutti @bensonr can you merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #350 by using Pa instead of pa and mbar instead of mb as units of pressure.
This should make the units of pressure generated by this repository machine-readable.
NOAA-EMC/fv3atm#859 makes other units machine-readable
Replaces #355
How Has This Been Tested?
I made similar changes to a version of this repository in global-workflow, which I then compiled and ran. This produced netCDF history files with machine-readable units (specifically the python pint program, though I also checked with UDUnits).
Checklist:
Please check all whether they apply or not