Fix mosaic2 tests with strict debug flags
#1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues that occur in the `mosaic2` tests when FMS is built using strict debug flags: 1) The `area` argument of `calc_mosaic_grid_area` has been changed from `intent(inout)` to `intent(out)`, to avoid an uninitialized value error. 2) `atan` has been changed to `atan2` in the unit tests, to avoid divide-by-zero errors.
J-Lentz
requested review from
uramirez8707,
bensonr and
rem1776
as code owners
|
@abrooks1085 Can you try this branch with ifx prod flags? See if it fixes the unit test crashes in mosaic2? |
| @@ -86,15 +86,13 @@ | |||
| !> <br>Example usage: | |||
| !! call calc_mosaic_grid_area(lon, lat, area) | |||
| subroutine CALC_MOSAIC_GRID_AREA_(lon, lat, area) | |||
| real(kind=FMS_MOS_KIND_), dimension(:,:), intent(in) :: lon | |||
| real(kind=FMS_MOS_KIND_), dimension(:,:), intent(in) :: lat | |||
| real(kind=FMS_MOS_KIND_), dimension(:,:), intent(inout) :: area | |||
There was a problem hiding this comment.
I am asking purely for my own learning and do not know what is best: Why would you decide to change the intent instead of just initializing the output variable in the code before this subroutine is called?
There was a problem hiding this comment.
CALC_MOSAIC_GRID_AREA_ is a wrapper around get_grid_area, which sets the area but doesn't read the value that's passed in. So intent(out) more clearly communicates to the user what the code is doing.
There was a problem hiding this comment.
Or in other words, there's no reason it should need to be initialized, because it gets set by get_grid_area.
rem1776
approved these changes
Oct 11, 2024
uramirez8707
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes two issues that occur in the
mosaic2tests when FMS is built using strict debug flags:The
areaargument ofcalc_mosaic_grid_areahas been changed fromintent(inout)tointent(out), to avoid an uninitialized value error.atanhas been changed toatan2in the unit tests, to avoid divide-by-zero errors.How Has This Been Tested?
Fixes the
mosaic2unit tests when FMS is built with ifort 2021.13.0 on the AMD box with the following debug flags:-check all -fpe0 -fp-stack-check -fstack-security-check -ftrapuv -init=arrays,minus_huge,snanChecklist:
make distcheckpasses