Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge mixed mode base into mixedmode #1352

Merged
merged 10 commits into from
Aug 25, 2023
Merged

merge mixed mode base into mixedmode #1352

merged 10 commits into from
Aug 25, 2023

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Aug 23, 2023

Description
merges mixedmode_base into mixedmode, brings in the latest main updates .

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@@ -214,7 +212,7 @@
endif

lon_strt = lon(1)
do i=2,len+1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something funky going on here? The mixedmode branch already contains this change and shouldn't show up here..? @J-Lentz, is this correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this because its merging mixedmode_base, that was just updated into mixedmode?

Copy link
Contributor Author

@rem1776 rem1776 Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like its from updating mixemode_base but not doing a merge commit with main so it views the commits as separate even though its the same changes. If you don't have a merge commit it just thinks its your own changes, when they should match up with the commits on the branch you are merging into. I'll try merging mixedmode into mixedmode_base and see if I can get this to go in cleanly.

After this merge I think we should get rid of mixedmode_base. The mixedmode braches should have the same includes and everything as mixedmode_base from merging our prs in, so we shouldn't need the other branch just for main updates. I think it would be cleaner and make more sense to merge main right into mixedmode and start our prs there, I can try it next time we need an update.

@rem1776 rem1776 merged commit 73d0461 into mixedmode Aug 25, 2023
67 checks passed
@rem1776 rem1776 deleted the mixedmode_base branch January 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants