Calls allocate_diag_field_output_buffers #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d setter functions)
…tions to get it to work
thomas-robinson
approved these changes
Aug 2, 2023
| @@ -226,7 +226,7 @@ module fms_diag_yaml_mod | |||
| character(len=:), allocatable, private :: diag_title !< Experiment name | |||
| integer, private, dimension (basedate_size) :: diag_basedate !< basedate array | |||
| type(diagYamlFiles_type), allocatable, public, dimension (:) :: diag_files!< History file info | |||
| type(diagYamlFilesVar_type), allocatable, private, dimension (:) :: diag_fields !< Diag fields info | |||
| type(diagYamlFilesVar_type), allocatable, public, dimension (:) :: diag_fields !< Diag fields info | |||
There was a problem hiding this comment.
We can do this for now, but we should really try to think of something better.
There was a problem hiding this comment.
:/ getter functions for both, but i am lazy
Also, the yaml object should be in diag_object like all the other objects
rem1776
approved these changes
Aug 7, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
diag_fieldspublic to be consistent withdiag_filesfms_diag_output_buffer_create_containerto a subroutine withintent(inout)(other members of the buffer objects are set somewhere else and if it is a function they will get deleted)allocate_diag_field_output_buffersallocate_diag_field_output_buffersFixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses