Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diag_field_not_found #1301

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

uramirez8707
Copy link
Contributor

Description
Return diag_field_not_found if a field is not in the diag_table.yaml when registering fields.

This is needed to reproduce previous behavior and because there is code in MOM that expects the result to be diag_field_not_found.

Fixes # (issue)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

!< The field was not found in the table, so return diag_null
fms_register_diag_field_obj = diag_null
!< The field was not found in the table, so return DIAG_FIELD_NOT_FOUND
fms_register_diag_field_obj = DIAG_FIELD_NOT_FOUND
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doxygen \return needs to be updated to reflect this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for the function needs to be updated because it can return diag_field_not_found now

@thomas-robinson thomas-robinson merged commit 4cb075e into NOAA-GFDL:dmUpdate Jul 31, 2023
27 checks passed
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
* Return diag_field_not_found if a field is not in the diag_table.yaml when registering fields
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
* Return diag_field_not_found if a field is not in the diag_table.yaml when registering fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants