Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PW CI pipeline update5 ready for review so it can be merged and tested #3059

Merged

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented Nov 1, 2024

Discription

Latest updates to CI GitHub Pipeline:

  • Explicitly gets owner of the repo from PRs when coming in from forked repos (was deficient on last iteration)
  • Updated to more current method to GITHUB_OUTPUT for inter job variable passing

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

NOTE: Many updates where used in the PR process as the pipeline development had to occur directly in the authoritative repo on the develop branch for testing actions/checkout@v4 when cloning from a forked repo.

How is this tested

Once the update is made in the default develop branch the action can be tested.
We can not test this from a forked repo because said test would require a fork of a fork.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added the CI/CD Issue related to CI/CD label Nov 1, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA changed the title Pw pipeline update5 PW CI pipeline update5 ready for review so it can be merged and tested Nov 1, 2024
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 5bde649 into NOAA-EMC:develop Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Issue related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants