-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move machine-based options from config.base to host files #3053
base: develop
Are you sure you want to change the base?
Move machine-based options from config.base to host files #3053
Conversation
This will break the |
There is an issue with the Marking ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a commendable PR and a key demonstration of how to refactor an "if-y diff-y" system specific configuration construct into a more centralized and pythonic approach. I particularly liked how you enhanced the formation of the defaulting overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things and one thing to sneak in (or leave for another time).
WCOSS is failing for a couple reasons:
Seems like the WCOSS upgrade changed something with jinja. CC @aerorahul |
Load Python module for WCOSS2 setup
Updated the WCOSS2 module files to load Python 3.8.6 into the environment. This should resolve the errors seen during CI testing and issue #3087. |
CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_3053/RUNTESTS on WCOSS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Thanks for including the fix to the jinja2 error on wcoss2
Description
This moves all machine-specific options to the workflow/hosts files from the config.* files.
This also turns HPSS archiving on for WCOSS2 by default.
Resolves #2942
Resolves #3087
Type of change
Change characteristics
How has this been tested?
CI testing on Hercules. The tracker and genesis jobs did not run (as expected).
WCOSS2 testing still needs to be performed.
Checklist