Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JGDAS ENKF ECEN job #3050

Merged
merged 7 commits into from
Nov 9, 2024
Merged

Update JGDAS ENKF ECEN job #3050

merged 7 commits into from
Nov 9, 2024

Conversation

mingshichen-noaa
Copy link
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jgdas enkf ecen job.

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

CoryMartin-NOAA
CoryMartin-NOAA reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there no changes for COM_ATMOS_ANALYSIS_STAT?

KateFriedman-NOAA
KateFriedman-NOAA reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second @CoryMartin-NOAA 's comment. Changes in this PR look good so far but there are other COM variables in scripts/exgdas_enkf_ecen.sh that also need to be updated to their COMIN/COMOUT versions. Please update those variables as well, thanks!

@mingshichen-noaa
Copy link
Contributor Author

@CoryMartin-NOAA @KateFriedman-NOAA
Hi both,
I am sorry to have missed git push. Right now I have made updating.

@KateFriedman-NOAA
Copy link
Member

I am sorry to have missed git push. Right now I have made updating.

@mingshichen-noaa Thanks for committing those additional updates. Question, the testing you did included these COM changes that you just pushed?

@mingshichen-noaa
Copy link
Contributor Author

Kate,
Yes, testing and git push were done yesterday.

KateFriedman-NOAA
KateFriedman-NOAA requested changes Nov 1, 2024
View reviewed changes
scripts/exgdas_enkf_ecen.sh Outdated Show resolved Hide resolved
scripts/exgdas_enkf_ecen.sh Outdated Show resolved Hide resolved
jobs/JGDAS_ENKF_ECEN Outdated Show resolved Hide resolved
@CoryMartin-NOAA
Copy link
Contributor

I agree with @KateFriedman-NOAA those are links to files produced by executables and thus should be COMOUT

@mingshichen-noaa
Copy link
Contributor Author

Kate,
I agree with your comments and suggestions. I have made change and done git add/commit/push them.

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are correct now. Approve pending successful completion of CI tests and approval by other reviewers.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Nov 5, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Nov 5, 2024
@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Nov 5, 2024
@emcbot
Copy link

emcbot commented Nov 5, 2024

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3050


Experiment C48_ATM_62510c21 Completed 2 Cycles: *SUCCESS* at Tue Nov  5 10:47:48 CST 2024
Experiment C96_S2SWA_gefs_replay_ics_62510c21 Completed 1 Cycles: *SUCCESS* at Tue Nov  5 10:53:56 CST 2024
Experiment C48_S2SW_62510c21 Completed 2 Cycles: *SUCCESS* at Tue Nov  5 11:48:40 CST 2024
Experiment C96C48_hybatmDA_62510c21 Completed 3 Cycles: *SUCCESS* at Tue Nov  5 12:37:35 CST 2024
Experiment C96_atm3DVar_62510c21 Completed 3 Cycles: *SUCCESS* at Tue Nov  5 12:43:36 CST 2024
Experiment C48_S2SWA_gefs_62510c21 Completed 1 Cycles: *SUCCESS* at Tue Nov  5 13:02:17 CST 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 8, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 8, 2024
@emcbot
Copy link

emcbot commented Nov 8, 2024

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3050


Experiment C48_ATM_62510c21 Completed 2 Cycles: *SUCCESS* at Fri Nov  8 12:46:18 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_62510c21 Completed 1 Cycles: *SUCCESS* at Fri Nov  8 12:52:51 UTC 2024
Experiment C48mx500_3DVarAOWCDA_62510c21 Completed 2 Cycles: *SUCCESS* at Fri Nov  8 13:05:16 UTC 2024
Experiment C48_S2SWA_gefs_62510c21 Completed 1 Cycles: *SUCCESS* at Fri Nov  8 14:01:03 UTC 2024
Experiment C96C48_hybatmDA_62510c21 Completed 3 Cycles: *SUCCESS* at Fri Nov  8 14:24:59 UTC 2024
Experiment C96_atm3DVar_62510c21 Completed 3 Cycles: *SUCCESS* at Fri Nov  8 14:37:06 UTC 2024
Experiment C96C48_hybatmaerosnowDA_62510c21 Completed 3 Cycles: *SUCCESS* at Fri Nov  8 14:43:13 UTC 2024
Experiment C48_S2SW_62510c21 Completed 2 Cycles: *SUCCESS* at Fri Nov  8 18:27:34 UTC 2024
Experiment C96C48_ufs_hybatmDA_62510c21 Completed 3 Cycles: *SUCCESS* at Fri Nov  8 18:33:46 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 3f68397 into NOAA-EMC:develop Nov 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mingshichen-noaa @KateFriedman-NOAA @CoryMartin-NOAA @emcbot @WalterKolczynski-NOAA @DavidHuber-NOAA