Add more ocean variables for post-processing in GEFS #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After testing this branch with the latest gfs_utils hash, the new ocean variable |
WalterKolczynski-NOAA
previously approved these changes
Oct 10, 2024
WalterKolczynski-NOAA
added
the
CI-Hercules-Ready
emcbot
added
CI-Hercules-Building
|
Experiment C96_S2SWA_gefs_replay_ics FAILED on Hercules in Build# 1 in |
emcbot
added
CI-Hercules-Failed
|
CI Failed on Hercules in Build# 1 |
WalterKolczynski-NOAA
added
CI-Hercules-Ready
emcbot
added
CI-Hercules-Building
|
@WalterKolczynski-NOAA Build fail with gfs_utils, seems to cause a Jenkins failure, not sure how the two are related: |
TerrenceMcGuinness-NOAA
added
CI-Hercules-Failed
|
@TerrenceMcGuinness-NOAA Did the build cause a Jenkins failure, or vice versa? The build log looks successful. |
38 tasks
EricSinsky-NOAA
added a commit
that referenced
this pull request
Oct 28, 2024
<!-- *** PLEASE READ *** Any PRs not following this template will be closed. Please delete all these comments before submitting the PR. Please use a short (<60 char), descriptive title for the PR title above. It should complete the sentence "If merged, this PR will _____". Capitalize the first word and do not end with a period. No content should appear above the "Description" header. If this PR is not merge-ready (e.g. it depends on other PRs not yet merged), please mark it as draft until it is ready. PRs should meet these guidelines: - Each PR should address ONE topic and have an associated issue. - No hard-coded paths or personal directories. - No temporary or backup files should be committed (including logs). - Any code that you disabled by being commented out should be removed or reenabled. --> # Description <!-- This description will become the commit message for the PR. --> <!-- Solely pointing to an issue is not an adequate description! Please use this format for your description: Describe your changes. Focus on the *what* and *why*. The *how* will be evident from the changes. In particular, be sure to note any interface changes, such as command line syntax, that will need to be communicated to users. At the end of your description, please be sure to add the issue this PR solves using the word "Resolves". If there are any issues that are related but not yet resolved (including in other repos), you may use "Refs". Resolves #1234 Refs #4321 Refs NOAA-EMC/repo#5678 --> This PR brings recent changes from the develop branch to the GEFS reforecast branch. This PR updates the GEFS reforecast branch to develop hash ac3cde5 (10/11/2024). This version of global-workflow uses the ufs-weather-model hash [6a4e09e](https://github.com/ufs-community/ufs-weather-model/tree/6a4e09e94773ffa39ce7ab6a54a885efada91f21) (9/9/2024). Furthermore, this PR ensures the following adjustments for the reforecast: - [x] Speed up rocoto by grouping post job - [x] Optimize PE configuration - [x] Remove duplicate OCNSPPT and EPBL settings - [x] Set restart_interval to fhmax - [x] Turn off SHUM in config.efcs - [x] Set FHMIN_WAV to 3 in config.base - [x] Turn off ATM history file output - [x] Change HMS=${cyc}0000 to HMS=030000 in Wavepostpnt script (#2788) - [x] Include YYYYMMDDHH (PDY) in job name - [x] Change CA seed based on case and cyc for control member and perturbed members - [x] Fix post ensemble info - [x] Add tob to ocean products (#2995 ) - [x] Move PEVPR from b group to a group for atmos products (#2995) - [x] Add option to download initial condition from HPSS - [x] Add ability to download and stage replay analysis from AWS, which is needed for the repair_replay task - [x] Add capability to run forecasts in 7-day intervals (#2928) - [x] Update defaults.yaml so that many of the reforecast-specific settings can be used by default <!-- For more on writing good commit messages, see https://cbea.ms/git-commit/ --> # Type of change - [ ] Bug fix (fixes something broken) - [ ] New feature (adds functionality) - [x] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics <!-- Choose YES or NO from each of the following and delete the other --> - Is this a breaking change (a change in existing functionality)? NO - Does this change require a documentation update? NO - Does this change require an update to any of the following submodules? NO - [ ] EMC verif-global <!-- NOAA-EMC/EMC_verif-global#1234 --> - [ ] GDAS <!-- NOAA-EMC/GDASApp#1234 --> - [ ] GFS-utils <!-- NOAA-EMC/gfs-utils#1234 --> - [ ] GSI <!-- NOAA-EMC/GSI#1234 --> - [ ] GSI-monitor <!-- NOAA-EMC/GSI-Monitor#1234 --> - [ ] GSI-utils <!-- NOAA-EMC/GSI-Utils#1234 --> - [ ] UFS-utils <!-- ufs-community/UFS_UTILS#1234 --> - [ ] UFS-weather-model <!-- ufs-community/ufs-weather-model#1234 --> - [ ] wxflow <!-- NOAA-EMC/wxflow#1234 --> # How has this been tested? <!-- Please list any test you conducted, including the machine. Example: - Clone and build on WCOSS - Cycled test on Orion - Forecast-only on Hera --> This branch is being tested on WCOSS2. When testing has succeeded, this PR will be marked as ready for review. # Checklist - [ ] Any dependent changes have been merged and published - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have documented my code, including function, input, and output descriptions - [ ] My changes generate no new warnings - [ ] New and existing tests pass with my changes - [ ] This change is covered by an existing CI test or a new one has been added - [ ] I have made corresponding changes to the system documentation if necessary --------- Co-authored-by: Wei Huang <[email protected]> Co-authored-by: Kate Friedman <[email protected]> Co-authored-by: Cory Martin <[email protected]> Co-authored-by: Andrew.Tangborn <[email protected]> Co-authored-by: Walter Kolczynski - NOAA <[email protected]> Co-authored-by: AndrewEichmann-NOAA <[email protected]> Co-authored-by: DavidBurrows-NCO <[email protected]> Co-authored-by: AnningCheng-NOAA <[email protected]> Co-authored-by: David Huber <[email protected]> Co-authored-by: Rahul Mahajan <[email protected]> Co-authored-by: AntonMFernando-NOAA <[email protected]> Co-authored-by: BoCui-NOAA <[email protected]> Co-authored-by: DavidNew-NOAA <[email protected]> Co-authored-by: Jeffrey Whitaker <[email protected]> Co-authored-by: mingshichen-noaa <[email protected]> Co-authored-by: Jiarui Dong <[email protected]> Co-authored-by: David Huber <[email protected]> Co-authored-by: Guillaume Vernieres <[email protected]> Co-authored-by: RussTreadon-NOAA <[email protected]> Co-authored-by: Innocent Souopgui <[email protected]> Co-authored-by: Neil Barton <[email protected]>
WalterKolczynski-NOAA
added
CI-Hera-Ready
emcbot
added
CI-Hercules-Building
|
CI Passed on Hercules in Build# 1 |
emcbot
added
CI-Hera-Passed
|
CI Passed on Hera in Build# 2 |
WalterKolczynski-NOAA
approved these changes
Nov 1, 2024
WalterKolczynski-NOAA
merged commit d95630a
into
NOAA-EMC:develop
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an ocean variable
tob(Sea Water Potential Temperature at Sea Floor) for post-processing in GEFS, which is a variable that has been requested for GEFSv13 and the reforecast.Also, this PR moves the atmos variable
PEVPRfrom the "b" group to the "a" group of pgrb products in GEFS. This was requested by a reforecast stakeholder.Resolves #2993
Type of change
Change characteristics
How has this been tested?
These changes have been tested on WCOSS2. This PR will be left as a draft until the necessary gfs-utils PR is merged.
Checklist