Add run and finalize methods to marine LETKF task #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We'll probably have to rearrange things between your PR and mine at some point, but this looks good to me. Thanks for doing this @AndrewEichmann-NOAA .
4 tasks
WalterKolczynski-NOAA
requested changes
Sep 27, 2024
| @@ -82,12 +82,14 @@ declare -rx COM_OCEAN_HISTORY_TMPL=${COM_BASE}'/model/ocean/history' | |||
| declare -rx COM_OCEAN_RESTART_TMPL=${COM_BASE}'/model/ocean/restart' | |||
| declare -rx COM_OCEAN_INPUT_TMPL=${COM_BASE}'/model/ocean/input' | |||
| declare -rx COM_OCEAN_ANALYSIS_TMPL=${COM_BASE}'/analysis/ocean' | |||
| declare -rx COM_OCEAN_LETKF_TMPL=${COM_BASE}'/analysis/ocean/letkf' | |||
There was a problem hiding this comment.
What files get written to the letkf directories vs the regular component analysis directories?
There was a problem hiding this comment.
These are the analysis files from the LETKF, which are separate from the variational analysis files
emcbot
added
the
CI-Hera-Failed
|
CI Failed on Hera in Build# 2 |
|
Failed due to a system issue with modules we've seen before. Going to restart the test and also get started testing elsewhere since all other tests passed. |
WalterKolczynski-NOAA
added
CI-Hera-Ready
emcbot
added
CI-Hercules-Building
WalterKolczynski-NOAA
added
the
CI-Wcoss2-Building
|
Running in |
WalterKolczynski-NOAA
added
CI-Wcoss2-Running
emcbot
added
CI-Hercules-Passed
|
CI Passed on Hercules in Build# 3 |
guillaumevernieres
approved these changes
Oct 30, 2024
emcbot
added
CI-Hera-Passed
|
CI Passed on Hera in Build# 4 |
WalterKolczynski-NOAA
added
CI-Wcoss2-Passed
WalterKolczynski-NOAA
approved these changes
Oct 30, 2024
WalterKolczynski-NOAA
merged commit 0b3304e
into
NOAA-EMC:develop
10 of 11 checks passed
guillaumevernieres
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Nov 7, 2024
Completes LETKF task, adds WCDA CI test Mutually dependent on NOAA-EMC/global-workflow#2944 --------- Co-authored-by: Cory Martin <[email protected]> Co-authored-by: Guillaume Vernieres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds run and finalize methods to marine LETKF task, experiment yaml for gw-ci in GDASApp, workflow additions, removes bugs found on the way, and completes the bulk of the work on LETKF task. Conversion of fields to increments pending.
Partially resolves NOAA-EMC/GDASApp#1091 and NOAA-EMC/GDASApp#1251
Mutual dependency with GDASApp PR NOAA-EMC/GDASApp#1287 and IC fix file issue #2944 (comment)
Type of change
Change characteristics
How has this been tested?
Example:
Checklist