Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global atmos vminmon job with COMIN/COMOUT for COM prefix #2939

Conversation

mingshichen-noaa
Copy link
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global minimization monitor job.

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

jobs/JGLOBAL_ATMOS_VMINMON Outdated Show resolved Hide resolved
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mingshichen-noaa !

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Sep 20, 2024
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Sep 20, 2024
@emcbot
Copy link

emcbot commented Sep 20, 2024

CI Update on Wcoss2 at 09/20/24 03:50:11 PM
============================================
Cloning and Building global-workflow PR: 2939
with PID: 181934 on host: clogin03

@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Sep 20, 2024
@emcbot
Copy link

emcbot commented Sep 20, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Fri Sep 20 15:55:34 UTC 2024 on clogin03
---------------------------------------------------
Build: Completed at 09/20/24 04:37:00 PM
Case setup: Completed for experiment C48_ATM_b0956d0f
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_b0956d0f
Case setup: Skipped for experiment C48_S2SWA_gefs_b0956d0f
Case setup: Completed for experiment C48_S2SW_b0956d0f
Case setup: Completed for experiment C96_atm3DVar_extended_b0956d0f
Case setup: Skipped for experiment C96_atm3DVar_b0956d0f
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_b0956d0f
Case setup: Completed for experiment C96C48_hybatmDA_b0956d0f
Case setup: Completed for experiment C96C48_ufs_hybatmDA_b0956d0f

@emcbot emcbot added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Sep 21, 2024
@emcbot
Copy link

emcbot commented Sep 21, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_b0956d0f *** SUCCESS *** at 09/20/24 06:00:29 PM
Experiment C48_S2SW_b0956d0f *** SUCCESS *** at 09/20/24 06:21:24 PM
Experiment C96C48_hybatmDA_b0956d0f *** SUCCESS *** at 09/20/24 06:56:32 PM
Experiment C96C48_hybatmaerosnowDA_b0956d0f *** SUCCESS *** at 09/20/24 07:42:30 PM
Experiment C96C48_ufs_hybatmDA_b0956d0f *** SUCCESS *** at 09/20/24 08:42:29 PM
Experiment C96_atm3DVar_extended_b0956d0f *** SUCCESS *** at 09/21/24 03:56:34 AM

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 7bdb362 into NOAA-EMC:develop Sep 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants