-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global atmos vminmon job with COMIN/COMOUT for COM prefix #2939
Merged
WalterKolczynski-NOAA
merged 7 commits into
NOAA-EMC:develop
from
mingshichen-noaa:feature/atmos_vminmon_com_in_out
Sep 21, 2024
Merged
Update global atmos vminmon job with COMIN/COMOUT for COM prefix #2939
WalterKolczynski-NOAA
merged 7 commits into
NOAA-EMC:develop
from
mingshichen-noaa:feature/atmos_vminmon_com_in_out
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingshichen-noaa
requested review from
WalterKolczynski-NOAA,
KateFriedman-NOAA and
aerorahul
September 18, 2024 21:10
WalterKolczynski-NOAA
requested changes
Sep 18, 2024
mingshichen-noaa
force-pushed
the
feature/atmos_vminmon_com_in_out
branch
from
September 20, 2024 14:14
c375c15
to
b0956d0
Compare
KateFriedman-NOAA
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @mingshichen-noaa !
WalterKolczynski-NOAA
approved these changes
Sep 20, 2024
WalterKolczynski-NOAA
added
the
CI-Wcoss2-Ready
**CM use only** PR is ready for CI testing on WCOSS
label
Sep 20, 2024
emcbot
added
CI-Wcoss2-Building
**Bot use only** CI testing is cloning/building on WCOSS
and removed
CI-Wcoss2-Ready
**CM use only** PR is ready for CI testing on WCOSS
labels
Sep 20, 2024
|
emcbot
added
CI-Wcoss2-Running
**Bot use only** CI testing on WCOSS for this PR is in-progress
and removed
CI-Wcoss2-Building
**Bot use only** CI testing is cloning/building on WCOSS
labels
Sep 20, 2024
Automated global-workflow Testing Results:
|
emcbot
added
CI-Wcoss2-Passed
**Bot use only** CI testing on WCOSS for this PR has completed successfully
and removed
CI-Wcoss2-Running
**Bot use only** CI testing on WCOSS for this PR is in-progress
labels
Sep 21, 2024
All CI Test Cases Passed on Wcoss2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global minimization monitor job.
Refs #2451
Type of change
Change characteristics
How has this been tested?
Checklist