Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update global atmos vminmon job to use COMIN/COMOUT #2935

Closed
wants to merge 5 commits into from
Closed

Update global atmos vminmon job to use COMIN/COMOUT #2935

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc26ccb
changed COM_* into COMIN/COMOUT
mingshichen-noaa Sep 16, 2024
3d3029a
remved the extra space on lines 20-21 after -rx
mingshichen-noaa Sep 17, 2024
29e73c3
changed prefix (COM_) of 3 variables into COMIN
mingshichen-noaa Sep 17, 2024
1b59c5c
revert the previous modifications
mingshichen-noaa Sep 18, 2024
90706ef
Merge branch 'develop' into feature/atmos_vminmon_com_in_out
mingshichen-noaa Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions jobs/JGLOBAL_ATMOS_VMINMON
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,19 @@ export gcyc=${GDATE:8:2}
#############################################
# TANKverf - WHERE OUTPUT DATA WILL RESIDE
#############################################
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COM_ATMOS_ANALYSIS
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COM_ATMOS_MINMON
YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx COM_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \
COMIN_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL \
COMOUT_ATMOS_MINMON:COM_ATMOS_MINMON_TMPL

export gsistat="${COM_ATMOS_ANALYSIS}/${RUN}.t${cyc}z.gsistat"
export M_TANKverf=${M_TANKverf:-${COM_ATMOS_MINMON}}
export M_TANKverfM1=${M_TANKverfM1:-${COM_ATMOS_MINMON_PREV}}
YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx \
COMOUT_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL

if [[ ! -d ${M_TANKverf} ]]; then mkdir -p -m 775 "${M_TANKverf}" ; fi
if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p -m 775 "${M_TANKverfM1}" ; fi
export gsistat="${COMIN_ATMOS_ANALYSIS}/${RUN}.t${cyc}z.gsistat"
export M_TANKverf=${M_TANKverf:-${COMOUT_ATMOS_MINMON}}
export M_TANKverfM1=${M_TANKverfM1:-${COMOUT_ATMOS_MINMON_PREV}}

if [[ ! -d ${M_TANKverf} ]]; then mkdir -p "${M_TANKverf}" ; fi
if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p "${M_TANKverfM1}" ; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only an input, we shouldn't be creating it.

Suggested change
if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p "${M_TANKverfM1}" ; fi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WalterKolczynski-NOAA
From scripts ( exglobal_atmos_vminmon.sh), these three directory variables should be input directories. Hence line 28 and 29 should be removed. Am I right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only $M_TANKverfM1 is an input. $M_TANKverif is an output (the perl scripts write to it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WalterKolczynski-NOAA
After reading 3 perl files in ush (minmon_xtrct_costs.pl minmon_xtrct_gnorms.pl minmon_xtrct_reduct.pl), gsistat should be only an input file defined in jobs/JGLOBAL_ATMOS_VMINMON. This implies the following modifications:
20 YMD=${PDY} HH=${cyc} declare_from_tmpl -rx
21 COMIN_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL
22 COMOUT_ATMOS_MINMON:COM_ATMOS_MINMON_TMPL
23
24 YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx
25 COMOUT_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL
26
27 export gsistat="${COMIN_ATMOS_ANALYSIS}/${RUN}.t${cyc}z.gsistat"
28 export M_TANKverf=${M_TANKverf:-${COMOUT_ATMOS_MINMON}}
29 export M_TANKverfM1=${M_TANKverfM1:-${COMOUT_ATMOS_MINMON_PREV}}
30
31 if [[ ! -d ${M_TANKverf} ]]; then mkdir -p "${M_TANKverf}" ; fi
32 if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p "${M_TANKverfM1}" ; fi
33

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What modifications are you proposing? That looks like what is there now.


########################################################
# Execute the script.
Expand Down
Loading