Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes to products for when REPLAY IC's are used #2755

Merged
merged 47 commits into from
Aug 13, 2024
Merged

Add fixes to products for when REPLAY IC's are used #2755

merged 47 commits into from
Aug 13, 2024

Commits on Jun 3, 2024

  1. Update linters.yaml 

    The linters.yaml has been updated so that shellnorms can run whenever a push occurs to EricSinsky-NOAA/develop.
    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9e6206c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Revert changes in linters.yaml 

    The changes to linters.yaml have been reverted.
    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    4e13fbe View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'NOAA-EMC:develop' into develop

    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1eb0c26 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'NOAA-EMC:develop' into develop

    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    720276b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge branch 'NOAA-EMC:develop' into develop

    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    219adb2 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'NOAA-EMC:develop' into develop

    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    37e2a6f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge branch 'NOAA-EMC:develop' into develop

    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b7ba980 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge branch 'NOAA-EMC:develop' into develop

    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a3efe66 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'NOAA-EMC:develop' into develop

    @EricSinsky-NOAA
    EricSinsky-NOAA authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    12e1ec1 View commit details
    Browse the repository at this point in the history

  2. Add changes related to offset 

    Changes have been added to account for the fixes needed to be made when there is an offset. These changes involve adjusting the atmosphere and ocean fhrs.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    557ac3f View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    6c2b7da View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    15de909 View commit details
    Browse the repository at this point in the history

  2. Replace NDATE with date 

    NDATE has been removed and has been replaced with date.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c1ddb4a View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c1ffe30 View commit details
    Browse the repository at this point in the history

  2. Move where replay diag_table is defined 

    The determination on whether or not the replay_diag_table should be used has been moved to config.fcst.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0dba84e View commit details
    Browse the repository at this point in the history

  3. Move dest_file outside if-statement 

    The dest_file variable has been moved outside of if-statement in forecast_postdet.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fb440c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5f393b1 View commit details
    Browse the repository at this point in the history

  2. Add bugfix in exglobal_stage_ic 

    A bugfix has been added in exglobal_stage_ic to ensure ${MEMDIR:3} is not intrepreted in base 8.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    dcb8066 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Revert "Add bugfix in exglobal_stage_ic" 

    This reverts commit dcb8066.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2936472 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8cf65f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Add fix for fv3 filename when fhr is decimal 

    A fix has been added for cases where there is an fhr that is a decimal number.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    77b00cf View commit details
    Browse the repository at this point in the history

  2. Address shell check error

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d1efec8 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Add more fixes for filename when fhr is decimal

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    78c4b59 View commit details
    Browse the repository at this point in the history

  2. Set default REPLAY_ICS to NO in predet/postdet

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5699dfc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ea4c3d5 View commit details
    Browse the repository at this point in the history

  4. Address shell check errors

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c2420d0 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2a477d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Give extractvars ability to process replay cases 

    Modifications have been made to the extractvars task so that data from replay cases can be extracted.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d7eb34a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c057a61 View commit details
    Browse the repository at this point in the history

  3. Fix bug in config.resources for extractvars 

    A bug has been fixed in config.resources that originated from changes from PR#2727.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f258475 View commit details
    Browse the repository at this point in the history

  4. Modify config.extractvars based on requirements 

    Some parameters in config.extractvars have been modified based on reforecast requirements.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dcbfd59 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d97dbf5 View commit details
    Browse the repository at this point in the history

  2. Condition based on REPLAY_ICS 

    A few if-blocks are conditioned based on REPLAY_ICS instead of OFFSET_START_HOUR.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    75b0d5a View commit details
    Browse the repository at this point in the history

  3. Rearange if-block to address reviewer comment 

    The if-block in forecast_predet has been rearranged so that it is more readable without compromising the general logic. Also FHMIN_REPLAY has been replaced by the already defined variable OFFSET_START_HOUR.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0e54133 View commit details
    Browse the repository at this point in the history

  4. Address shellcheck error

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    23a146b View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    44d6e59 View commit details
    Browse the repository at this point in the history

  2. Make variable FV3_OUTPUT_FH_s local

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    f3a0ad7 View commit details
    Browse the repository at this point in the history

  3. Avoid exporting arrays in bash

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    7a8f6ba View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Fix potential bug 

    Fix a bug that would occur if REPLAY_ICS are used, an FHOUT of 6 is used and no FHOUT_HF_GFS is used.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c28c2a0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    bd5b258 View commit details
    Browse the repository at this point in the history

  3. Organize netcdf comout directories for ocniceprod 

    The Netcdf ocean and ice products have been separated into subdirectories based on product grid. This is consistent with how the Grib2 ocean and ice products are organized.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    6476218 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    73a5101 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    57107f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Merge remote-tracking branch 'EMC/develop' into feature/offsetfixes

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d5d1efb View commit details
    Browse the repository at this point in the history

  2. Extract ice products with native grid instead

    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    57d6b11 View commit details
    Browse the repository at this point in the history

  3. Remove unused local variable 

    The local variable iicnt has been removed from forecast_postdet.sh since it is no longer being used.
    @EricSinsky-NOAA
    EricSinsky-NOAA committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d443bf9 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'develop' into feature/offsetfixes

    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    aaab44a View commit details
    Browse the repository at this point in the history