Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update omega calculation #2751

Merged
merged 12 commits into from
Aug 23, 2024
Merged

Update omega calculation #2751

merged 12 commits into from
Aug 23, 2024

Conversation

XiaqiongZhou-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented Jul 8, 2024 •
edited
Loading

Description

Add a parameter "pass_full_omega_to_physics_in_non_hydrostatic_mode" in FV3 namelist. It was set to "true" to use a new method to diagnose omega. This PR is based on the ufs_weather_model PR#2327

Corresponding parameter changed in GFSv17 related regression tests (PR#2373)

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Forecast-only on WCOSS2

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review July 8, 2024 17:29
DavidHuber-NOAA
DavidHuber-NOAA reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR need to update the UFS hash to ufs-community/ufs-weather-model@8e7b61b to capture this new feature?

@XiaqiongZhou-NOAA
Copy link
Contributor Author

Yes, otherwise, the new namelist parameter added can not be recognized by the model.

@DavidHuber-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA Would you be able to update the hash in the PR, then?

@aerorahul
Copy link
Contributor

FYI @JessicaMeixner-NOAA @NeilBarton-NOAA
This update will change the current default settings for GFSv17 and GEFSv13.

@JessicaMeixner-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA - I do not see this parameter updated in the GFSv17 tests in the PR you mentioned ufs-community/ufs-weather-model#2327 So I'm a little concerned about changing answers here when we don't have the corresponding changes in the GFSv17 tests in ufs-weather-model.

Also FYI to @CatherineThomas-NOAA

@XiaqiongZhou-NOAA
Copy link
Contributor Author

@XiaqiongZhou-NOAA - I do not see this parameter updated in the GFSv17 tests in the PR you mentioned ufs-community/ufs-weather-model#2327 So I'm a little concerned about changing answers here when we don't have the corresponding changes in the GFSv17 tests in ufs-weather-model.

Also FYI to @CatherineThomas-NOAA

This is not updated in ufs-weather-model. We would wait for the tests to see the impact on HAFS and RRFS. It was tested for GFSv17 and I will talk more on GFSv17/GEFSv13 meeting tomorrow.

@aerorahul aerorahul added the blocked Issue is currently being blocked by another issue label Jul 8, 2024
@JessicaMeixner-NOAA
Copy link
Contributor

JessicaMeixner-NOAA commented Jul 8, 2024 •
edited
Loading

The GFSv17 tests https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/rt.conf#L27-L32 and https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/rt.conf#L38-L39 are just settings for GFSv17 and do not have impact on HAFS or RRFS. Adding the setting updates here means that we ensure the new settings meet the reproducibility and other settings.

@XiaqiongZhou-NOAA
Copy link
Contributor Author

The GFSv17 tests https://docs.google.com/document/d/1usaJk0KmZAl7rNAVNojZD6-7lnbMVWXcLL6P6mIchMI/edit?usp=sharing and https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/rt.conf#L38-L39 are just settings for GFSv17 and do not have impact on HAFS or RRFS. Adding the setting updates here means that we ensure the new settings meet the reproducibility and other settings.

We plan to set this parameter =. true. as the default for all applications not just for GFSv17, so would like to see the impact on HAFS/RRFS before we change the setting for all regression tests.

@JessicaMeixner-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA before we use this in the global-workflow, we should have this turned on in the regression tests for GFSv17 in ufs-weather-model. It can always be subsequently updated for other systems as well.

JessicaMeixner-NOAA
JessicaMeixner-NOAA requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure this has been tested in ufs-waether-model GFSv17 tests before moving forward with this PR.

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA mentioned this pull request Jul 15, 2024
Merged
14 tasks
This was referenced Jul 19, 2024
Closed
Merged
@yangfanglin
Copy link
Contributor

We need to make sure this has been tested in ufs-waether-model GFSv17 tests before moving forward with this PR.

@XiaqiongZhou-NOAA Kate, what is the status of this PR ? Were you able to update the ufs-weather-model RTs ? If not, what is blocking the update ?

@XiaqiongZhou-NOAA
Copy link
Contributor Author

XiaqiongZhou-NOAA commented Jul 29, 2024 •
edited
Loading

Corresponding parameter changed in GFSv17 related regression tests (PR#2373)

It seems it will be merged soon.

@XiaqiongZhou-NOAA
Copy link
Contributor Author

The namelist related to this PR was changed in the regression tests and PR 2373 (ufs-community/ufs-weather-model#2373) was merged to ufs_model . Please update the workflow.

@aerorahul
Copy link
Contributor

@XiaqiongZhou-NOAA Please resolve the conflicts and ensure the hash of the ufs_model.fd is the right one you wish to use with this branch. Thanks!

@emcbot
Copy link

emcbot commented Aug 22, 2024 

CI Update on Wcoss2 at 08/22/24 04:26:05 PM
============================================
Cloning and Building global-workflow PR: 2751
with PID: 192419 on host: clogin03

@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Aug 22, 2024
@emcbot
Copy link

emcbot commented Aug 22, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Thu Aug 22 16:31:55 UTC 2024 on clogin03
---------------------------------------------------
Build: Completed at 08/22/24 05:16:07 PM
Case setup: Completed for experiment C48_ATM_92f644f8
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_92f644f8
Case setup: Skipped for experiment C48_S2SWA_gefs_92f644f8
Case setup: Completed for experiment C48_S2SW_92f644f8
Case setup: Completed for experiment C96_atm3DVar_extended_92f644f8
Case setup: Skipped for experiment C96_atm3DVar_92f644f8
Case setup: Completed for experiment C96_atmaerosnowDA_92f644f8
Case setup: Completed for experiment C96C48_hybatmDA_92f644f8
Case setup: Completed for experiment C96C48_ufs_hybatmDA_92f644f8

@emcbot emcbot added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Aug 23, 2024
@emcbot
Copy link

emcbot commented Aug 23, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_92f644f8 *** SUCCESS *** at 08/22/24 06:35:14 PM
Experiment C48_S2SW_92f644f8 *** SUCCESS *** at 08/22/24 06:49:11 PM
Experiment C96C48_hybatmDA_92f644f8 *** SUCCESS *** at 08/22/24 07:28:25 PM
Experiment C96_atmaerosnowDA_92f644f8 *** SUCCESS *** at 08/22/24 08:21:41 PM
Experiment C96C48_ufs_hybatmDA_92f644f8 *** SUCCESS *** at 08/22/24 08:56:32 PM
Experiment C96_atm3DVar_extended_92f644f8 *** SUCCESS *** at 08/23/24 04:42:38 AM

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Aug 23, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Aug 23, 2024
@emcbot
Copy link

emcbot commented Aug 23, 2024

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2751


Experiment C48_ATM_92f644f8 Completed 1 Cycles: *SUCCESS* at Fri Aug 23 05:17:55 CDT 2024
Experiment C96_atm3DVar_92f644f8 Completed 3 Cycles: *SUCCESS* at Fri Aug 23 06:36:38 CDT 2024
Experiment C96C48_hybatmDA_92f644f8 Completed 3 Cycles: *SUCCESS* at Fri Aug 23 06:36:39 CDT 2024
Experiment C48_S2SW_92f644f8 Completed 1 Cycles: *SUCCESS* at Fri Aug 23 06:48:36 CDT 2024
Experiment C48_S2SWA_gefs_92f644f8 Completed 1 Cycles: *SUCCESS* at Fri Aug 23 07:32:00 CDT 2024

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Aug 23, 2024
@emcbot
Copy link

emcbot commented Aug 23, 2024

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/2751


Experiment C48mx500_3DVarAOWCDA_92f644f8 Completed 2 Cycles: *SUCCESS* at Fri Aug 23 10:35:03 UTC 2024
Experiment C48_ATM_92f644f8 Completed 1 Cycles: *SUCCESS* at Fri Aug 23 10:35:03 UTC 2024
Experiment C96C48_hybatmDA_92f644f8 Completed 3 Cycles: *SUCCESS* at Fri Aug 23 11:42:02 UTC 2024
Experiment C96_atm3DVar_92f644f8 Completed 3 Cycles: *SUCCESS* at Fri Aug 23 11:47:58 UTC 2024
Experiment C48_S2SWA_gefs_92f644f8 Completed 1 Cycles: *SUCCESS* at Fri Aug 23 12:07:18 UTC 2024
Experiment C48_S2SW_92f644f8 Completed 1 Cycles: *SUCCESS* at Fri Aug 23 12:18:20 UTC 2024
Experiment C96_atmaerosnowDA_92f644f8 Completed 3 Cycles: *SUCCESS* at Fri Aug 23 12:42:40 UTC 2024

WalterKolczynski-NOAA
WalterKolczynski-NOAA requested changes Aug 23, 2024
View reviewed changes
parm/config/gefs/config.fcst Outdated Show resolved Hide resolved
parm/config/gfs/config.fcst Outdated Show resolved Hide resolved
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ea22a73 into NOAA-EMC:develop Aug 23, 2024
5 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 28, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/early_run_configs
473d47b 
* origin/develop:
  Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857)
  Support ATM forecast only on Google (NOAA-EMC#2832)
  Add GEFS C48 support on AWS (NOAA-EMC#2818)
  Update omega calculation (NOAA-EMC#2751)
  Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690)
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
386a940 
* origin/develop:
  Create JEDI class (NOAA-EMC#2805)
  Restructure the bufr sounding job    (NOAA-EMC#2853)
  Add an archive task to GEFS system to archive files locally (NOAA-EMC#2816)
  Reenable Orion Cycling Support (NOAA-EMC#2877)
  Eliminate race conditions and remove DATAROOT last in cleanup (NOAA-EMC#2893)
  Update aerosol climatology to 2013-2024 mean (NOAA-EMC#2888)
  Add ability to run CI test C96_atm3DVar.yaml to Gaea-C5 (NOAA-EMC#2885)
  Support global-workflow GEFS C48 on Google Cloud (NOAA-EMC#2861)
  Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876)
  Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738)
  Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868)
  Support coupling on AWS (NOAA-EMC#2859)
  Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
  Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857)
  Support ATM forecast only on Google (NOAA-EMC#2832)
  Add GEFS C48 support on AWS (NOAA-EMC#2818)
  Update omega calculation (NOAA-EMC#2751)
  Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690)
  support ATM forecast only on Azure (NOAA-EMC#2827)
  Convert staging job to python and yaml (NOAA-EMC#2651)
  Fixed test on UNAVAILBLE in python Rocoto check (NOAA-EMC#2842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA left review comments

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA requested changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@NeilBarton-NOAA NeilBarton-NOAA Awaiting requested review from NeilBarton-NOAA

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@XiaqiongZhou-NOAA @DavidHuber-NOAA @aerorahul @JessicaMeixner-NOAA @yangfanglin @WalterKolczynski-NOAA @emcbot @CatherineThomas-NOAA @RuiyuSun