Add diffusion/diag B for aerosol DA and some other needed changes #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lobal-workflow into feature/aero-b
…lobal-workflow into feature/aero-b
Added tasks to construct aero_diffparm.yaml from template.
WalterKolczynski-NOAA
requested changes
Aug 28, 2024
| pass | ||
|
|
||
| @logit(logger) | ||
| def computeVariance(self) -> None: |
There was a problem hiding this comment.
Python style guidelines say method names should be snake case, not camel case.
Suggested change
| def computeVariance(self) -> None: | |
| def compute_variance(self) -> None: |
| pass | ||
|
|
||
| @logit(logger) | ||
| def computeDiffusion(self) -> None: |
There was a problem hiding this comment.
Suggested change
| def computeDiffusion(self) -> None: | |
| def compute_diffusion(self) -> None: |
| self.link_jediexe() | ||
|
|
||
| @logit(logger) | ||
| def interpBackground(self) -> None: |
There was a problem hiding this comment.
Suggested change
| def interpBackground(self) -> None: | |
| def interp_background(self) -> None: |
| @logit(logger) | ||
| def execute(self: Analysis) -> None: | ||
| def variational(self: Analysis) -> None: |
There was a problem hiding this comment.
Best verb I could come up with here, open to others.
Suggested change
| def variational(self: Analysis) -> None: | |
| def var_assimilate(self: Analysis) -> None: |
| @@ -19,4 +19,4 @@ | |||
|
|
|||
| # Instantiate the aerosol analysis task | |||
| AeroAnl = AerosolAnalysis(config) | |||
| AeroAnl.execute() | |||
| AeroAnl.variational() | |||
There was a problem hiding this comment.
Suggested change
| AeroAnl.variational() | |
| AeroAnl.var_assimilate() |
Comment on lines
+24
to
+26
| AeroB.interpBackground() | ||
| AeroB.computeVariance() | ||
| AeroB.computeDiffusion() |
There was a problem hiding this comment.
Suggested change
| AeroB.interpBackground() | |
| AeroB.computeVariance() | |
| AeroB.computeDiffusion() | |
| AeroB.interp_background() | |
| AeroB.compute_variance() | |
| AeroB.compute_diffusion() |
WalterKolczynski-NOAA
previously approved these changes
Aug 28, 2024
emcbot
added
CI-Wcoss2-Passed
|
All CI Test Cases Passed on Wcoss2: |
|
@CoryMartin-NOAA Looks like merging Russ's PR created a conflict |
|
@WalterKolczynski-NOAA resolved |
WalterKolczynski-NOAA
added
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
CI Passed on Hera in Build# 2 |
emcbot
added
CI-Hercules-Building
|
CI Passed on Hercules in Build# 1 |
WalterKolczynski-NOAA
approved these changes
Aug 29, 2024
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Aug 30, 2024
* origin/develop: Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876) Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738) Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868) Support coupling on AWS (NOAA-EMC#2859) Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Sep 9, 2024
* origin/develop: Create JEDI class (NOAA-EMC#2805) Restructure the bufr sounding job (NOAA-EMC#2853) Add an archive task to GEFS system to archive files locally (NOAA-EMC#2816) Reenable Orion Cycling Support (NOAA-EMC#2877) Eliminate race conditions and remove DATAROOT last in cleanup (NOAA-EMC#2893) Update aerosol climatology to 2013-2024 mean (NOAA-EMC#2888) Add ability to run CI test C96_atm3DVar.yaml to Gaea-C5 (NOAA-EMC#2885) Support global-workflow GEFS C48 on Google Cloud (NOAA-EMC#2861) Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876) Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738) Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868) Support coupling on AWS (NOAA-EMC#2859) Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833) Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857) Support ATM forecast only on Google (NOAA-EMC#2832) Add GEFS C48 support on AWS (NOAA-EMC#2818) Update omega calculation (NOAA-EMC#2751) Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690) support ATM forecast only on Azure (NOAA-EMC#2827) Convert staging job to python and yaml (NOAA-EMC#2651) Fixed test on UNAVAILBLE in python Rocoto check (NOAA-EMC#2842)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in support for computing files needed for the aerosol analysis B. This includes a new task,
aeroanlgenb. This work was performed by both me and @andytangbornResolves #2501
Resolves #2737
Please note, I am still using python to create dictionaries for FileHandler. This will not be resolved in this PR but a future PR, an issue #2737 has been created to make note of this.EDIT: this PR has been added to such that the above is no longer true
Type of change
Change characteristics
How has this been tested?
Checklist