Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for deprecated numpy versions. #1726

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Updates for deprecated numpy versions. #1726

merged 1 commit into from
Jul 6, 2023

Conversation

HenryRWinterbottom
Copy link
Contributor

@HenryRWinterbottom HenryRWinterbottom commented Jul 6, 2023

Description

Using numpy to cast type has been deprecated in favor of using the native python functions (i.e. int(), float(), etc.).

Resolves #1725.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Rocoto workflow is successfully configured. CI will be the ultimate test.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@HenryRWinterbottom HenryRWinterbottom self-assigned this Jul 6, 2023
@HenryRWinterbottom HenryRWinterbottom added the bug Something isn't working label Jul 6, 2023
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit e64b225 into NOAA-EMC:develop Jul 6, 2023
@HenryRWinterbottom HenryRWinterbottom deleted the bug/deprecated_numpy branch July 13, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy deprecation
3 participants